Summary: | Add a baseURL parameter to _WKUserStyleSheet | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | commit-queue, gyuyoung.kim, jberlin, ryanhaddad | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | 155317 | ||||||||||||||||||||
Bug Blocks: | 155488 | ||||||||||||||||||||
Attachments: |
|
Description
Sam Weinig
2016-03-08 21:57:29 PST
Created attachment 273499 [details]
Patch
Attachment 273499 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:75: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:400: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:408: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/page/UserContentController.h:63: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
ERROR: Source/WebCore/page/UserContentController.h:64: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
ERROR: Source/WebCore/loader/EmptyClients.cpp:106: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
ERROR: Source/WebCore/page/UserContentProvider.h:81: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:305: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:353: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5208: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5215: Missing space before { [whitespace/braces] [5]
Total errors found: 13 in 42 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 273522 [details]
Patch
Attachment 273522 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:75: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:400: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:408: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/page/UserContentController.h:63: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
ERROR: Source/WebCore/page/UserContentController.h:64: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
ERROR: Source/WebCore/loader/EmptyClients.cpp:106: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4]
ERROR: Source/WebCore/page/UserContentProvider.h:81: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:305: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:353: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5212: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5219: Missing space before { [whitespace/braces] [5]
Total errors found: 13 in 42 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 273522 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273522&action=review Seems pretty reasonable. Needs an API test. And a bunch of build fixes. > Source/WebCore/page/UserMessageHandlersNamespace.cpp:-60 > - const auto* userMessageHandlerDescriptors = userContentController->userMessageHandlerDescriptors(); We use this map again further down, this is why the build is broken. At least, one of the reasons. > Source/WebKit2/WebProcess/UserContent/WebUserContentController.h:41 > + class CompiledContentExtension; unindent Created attachment 273575 [details]
Patch
Attachment 273575 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:75: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:410: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:418: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:305: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:353: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5220: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5227: Missing space before { [whitespace/braces] [5]
Total errors found: 8 in 42 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r197943: <http://trac.webkit.org/changeset/197943> This change appears to have broken the Windows build <https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/76263> C:\cygwin\home\buildbot\slave\win-release\build\Source\WebKit\win\WebView.cpp(2942): error C2039: 'userContentController': is not a member of 'WebCore::PageConfiguration' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/PageConfiguration.h(59): note: see declaration of 'WebCore::PageConfiguration' C:\cygwin\home\buildbot\slave\win-release\build\Source\WebKit\win\WebView.cpp(3862): error C2039: 'setUserContentController': is not a member of 'WebCore::Page' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj] c:\cygwin\home\buildbot\slave\win-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\UserContentProvider.h(48): note: see declaration of 'WebCore::Page' Re-opened since this is blocked by bug 155317 Created attachment 274002 [details]
Patch
Attachment 274002 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:75: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:410: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:418: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:305: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:353: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5227: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5234: Missing space before { [whitespace/braces] [5]
Total errors found: 8 in 43 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 274006 [details]
Patch
Attachment 274006 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:75: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:410: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:418: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:305: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:353: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5227: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5234: Missing space before { [whitespace/braces] [5]
Total errors found: 8 in 43 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 274012 [details]
Patch
Attachment 274012 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:75: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:410: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:418: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:305: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:353: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5227: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5234: Missing space before { [whitespace/braces] [5]
Total errors found: 8 in 44 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 274046 [details]
Patch
Attachment 274046 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:75: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:410: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:418: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:305: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:353: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5227: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5234: Missing space before { [whitespace/braces] [5]
Total errors found: 8 in 44 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 274054 [details]
Patch
Attachment 274054 [details] did not pass style-queue:
ERROR: Source/WebCore/page/UserContentController.cpp:75: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/page/UserContentController.cpp:102: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:410: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:418: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:305: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:353: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5227: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5234: Missing space before { [whitespace/braces] [5]
Total errors found: 8 in 45 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r198180: <http://trac.webkit.org/changeset/198180> (In reply to comment #22) > Committed r198180: <http://trac.webkit.org/changeset/198180> r198180 broke EFL build. I fix it in Bug 155488. |