Summary: | Add proper JSON.stringify support for Proxy when the target is an array | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Saam Barati
2016-03-08 11:43:26 PST
Created attachment 273519 [details]
patch
Comment on attachment 273519 [details] patch Clearing flags on attachment: 273519 Committed r197918: <http://trac.webkit.org/changeset/197918> All reviewed patches have been landed. Closing bug. Comment on attachment 273519 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=273519&action=review > Source/JavaScriptCore/runtime/ArrayConstructor.h:91 > + ASSERT_NOT_REACHED(); I didn't catch this before, but you should probably make this a RELEASE_ASSERT_NOT_REACHED(). Comment on attachment 273519 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=273519&action=review >> Source/JavaScriptCore/runtime/ArrayConstructor.h:91 >> + ASSERT_NOT_REACHED(); > > I didn't catch this before, but you should probably make this a RELEASE_ASSERT_NOT_REACHED(). Nevermind. Saam reminded me (offline) that this comes after an infinite loop. Short of a compiler error, there's really no way to reach this point. The debug assert is good enough if only for documentation (in case someone re-writes the loop in the future to not be an infinite loop). |