Bug 155180

Summary: Add proper JSON.stringify support for Proxy when the target is an array
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2016-03-08 11:43:26 PST
...
Attachments
patch (10.48 KB, patch)
2016-03-09 17:35 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-03-09 17:35:35 PST
Created attachment 273519 [details] patch
WebKit Commit Bot
Comment 2 2016-03-09 18:41:22 PST
Comment on attachment 273519 [details] patch Clearing flags on attachment: 273519 Committed r197918: <http://trac.webkit.org/changeset/197918>
WebKit Commit Bot
Comment 3 2016-03-09 18:41:26 PST
All reviewed patches have been landed. Closing bug.
Mark Lam
Comment 4 2016-03-09 23:28:50 PST
Comment on attachment 273519 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=273519&action=review > Source/JavaScriptCore/runtime/ArrayConstructor.h:91 > + ASSERT_NOT_REACHED(); I didn't catch this before, but you should probably make this a RELEASE_ASSERT_NOT_REACHED().
Mark Lam
Comment 5 2016-03-09 23:57:46 PST
Comment on attachment 273519 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=273519&action=review >> Source/JavaScriptCore/runtime/ArrayConstructor.h:91 >> + ASSERT_NOT_REACHED(); > > I didn't catch this before, but you should probably make this a RELEASE_ASSERT_NOT_REACHED(). Nevermind. Saam reminded me (offline) that this comes after an infinite loop. Short of a compiler error, there's really no way to reach this point. The debug assert is good enough if only for documentation (in case someone re-writes the loop in the future to not be an infinite loop).
Note You need to log in before you can comment on or make changes to this bug.