Summary: | Implement rel=noopener | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mathias Bynens <mathias> | ||||||
Component: | DOM | Assignee: | Andy Estes <aestes> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, aestes, alwillis, ap, bfulgham, cdumez, commit-queue, darin, dbates, esprehn+autocc, gyuyoung.kim, japhet, koivisto, mathias, m.goleb+bugzilla, mkwst, sam, teppeis, webkit-bug-importer, wilander, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
http://code.google.com/p/chromium/issues/detail?id=168988 https://bugs.webkit.org/show_bug.cgi?id=163960 |
||||||||
Attachments: |
|
Description
Mathias Bynens
2016-03-08 02:42:10 PST
CCing potentially interested folks. Created attachment 292690 [details]
Patch
We should also support the "noopener" feature for window.open(). I'll file a separate bug about that. Comment on attachment 292690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292690&action=review > Source/WebCore/html/HTMLAnchorElement.cpp:-252 > - // Update HTMLAnchorElement::relList() if more rel attributes values are supported. I didn't mean to remove this comment. I'll restore it before landing. Comment on attachment 292690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292690&action=review r=me > Source/WebCore/html/HTMLAnchorElement.h:-55 > -// RelationUp = 0x00020000, Are all of these implemented now? :-) (In reply to comment #6) > Comment on attachment 292690 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=292690&action=review > > r=me > > > Source/WebCore/html/HTMLAnchorElement.h:-55 > > -// RelationUp = 0x00020000, > > Are all of these implemented now? :-) No, but there's no point in leaving the list of unimplemented values in a comment. The HTML spec is the right place for that list. And thanks for the review :) Created attachment 292786 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 292786 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 292786 [details]:
The commit-queue is continuing to process your patch.
Comment on attachment 292786 [details] Patch Clearing flags on attachment: 292786 Committed r207840: <http://trac.webkit.org/changeset/207840> All reviewed patches have been landed. Closing bug. |