Bug 155154

Summary: WeakBlock::visit() should check for a WeakHandleOwner before consulting mark bits.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2016-03-07 19:13:08 PST
Many WeakImpl's do not have a WeakHandleOwner, so WeakBlock::visit() is just wasting its time looking up the mark bits for its pointee.
Attachments
Patch (1.98 KB, patch)
2016-03-07 19:13 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2016-03-07 19:13:37 PST
Created attachment 273260 [details] Patch
Darin Adler
Comment 2 2016-03-08 09:09:40 PST
Comment on attachment 273260 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273260&action=review > Source/JavaScriptCore/heap/WeakBlock.cpp:121 > + const JSValue& jsValue = weakImpl->jsValue(); The use of const JSValue& here seems peculiar. Why not just JSValue?
WebKit Commit Bot
Comment 3 2016-03-08 09:56:57 PST
Comment on attachment 273260 [details] Patch Clearing flags on attachment: 273260 Committed r197774: <http://trac.webkit.org/changeset/197774>
WebKit Commit Bot
Comment 4 2016-03-08 09:57:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.