Bug 15514 – <clipPath> with <use> not respected

• Component: SVG
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

SVG displays extra black transparent square

http://www.carto.net/neumann/cartography/papermaps/japan.svgz

not sure why.  needs reduction.

[Eric Seidel (no email)]

These have the same issue:
http://www.carto.net/neumann/cartography/papermaps/korea.svgz
http://www.carto.net/neumann/cartography/papermaps/china.svgz

[Eric Seidel (no email)]

Turn out this is a problem with our <clipPath> and <use> support.

[Eric Seidel (no email)]

Created attachment 16675 [details]
test case

[Rob Buis]

Created attachment 18107 [details]
First attempt

I fixed the bug but also tried to look at the functionality of using <use> from a clip path a bit more, particularly the part that describes indirect references are disallowed. The second testcase tests this, Opera and Firefox do allow that clip path, so either I am misunderstanding the spec or they are wrong.
Cheers,

Rob.

[Eric Seidel (no email)]

You are the most wonderful bug sniper ever!  All these old little bugs slowly getting picked off by Rob... one at a time... :)

I'll actually review your patch after all the xmas celebration (assuming no one else beats me to it).

[Eric Seidel (no email)]

Comment on attachment 18107 [details]
First attempt

A few comments.

1.  You might mention the section of the spec, or even the text, indicating the direct reference requirement:

14.3.5 Establishing a new clipping path
A 'clipPath' element can contain 'path' elements, 'text' elements, basic shapes (such as 'circle') or a 'use' element. If a 'use' element is a child of a 'clipPath' element, it must directly reference 'path', 'text' or basic shape elements.

Single line ifs (including those with comments) do no use { } according to the webkit style guidelines.

Otherwise looks great.  I assume that both test cases show 100x100 green rects on TOT?

r=me, assuming you fix the spec comment and style issue.

[Rob Buis]

Landed in r28991.

[Eric Seidel (no email)]

*** Bug 16557 has been marked as a duplicate of this bug. ***