Bug 155129

Summary: [iOS] Arabic text on Wikipedia is shown as boxes
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fujii.hironori, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch none

Myles C. Maxfield
Reported 2016-03-07 13:30:20 PST
[iOS] Arabic text on Wikipedia is shown as boxes
Attachments
WIP (2.80 KB, patch)
2016-03-07 13:30 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (7.43 KB, patch)
2016-03-08 15:10 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (7.47 KB, patch)
2016-03-08 15:54 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-03-07 13:30:50 PST
Created attachment 273205 [details] WIP
Myles C. Maxfield
Comment 2 2016-03-07 13:34:46 PST
Comment on attachment 273205 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=273205&action=review > Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:116 > + fallbackFontDescriptor = adoptCF(CTFontDescriptorCreateMatchingFontDescriptor(adoptCF(CTFontDescriptorCreateWithAttributes(fallbackAttributes.get())).get(), nullptr)); Perhaps we should say the family name is a required attribute
Myles C. Maxfield
Comment 3 2016-03-08 15:10:43 PST
Created attachment 273344 [details] Patch
Myles C. Maxfield
Comment 4 2016-03-08 15:11:36 PST
<rdar://problem/24919902>
Myles C. Maxfield
Comment 5 2016-03-08 15:11:47 PST
Comment on attachment 273344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273344&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=155129 <rdar://problem/24919902>
Myles C. Maxfield
Comment 6 2016-03-08 15:54:38 PST
Created attachment 273357 [details] Patch
Darin Adler
Comment 7 2016-03-08 18:06:59 PST
Comment on attachment 273357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273357&action=review > LayoutTests/ChangeLog:16 > + * fast/text/arabic-blacklisted-expected.html: Added. > + * fast/text/arabic-blacklisted.html: Added. Since the test is iOS-specific, the correct way to add it would be to put it somewhere inside platform/ios instead having all the other platforms ignore the test.
Simon Fraser (smfr)
Comment 8 2016-03-08 18:34:53 PST
We're trying to avoid putting tests in platform/, since people forget to run them, and they create results in platform/foo/platform/foo/thing directories. I think I mentioned this on webkit-dev.
WebKit Commit Bot
Comment 9 2016-03-09 00:54:46 PST
Comment on attachment 273357 [details] Patch Clearing flags on attachment: 273357 Committed r197847: <http://trac.webkit.org/changeset/197847>
WebKit Commit Bot
Comment 10 2016-03-09 00:54:51 PST
All reviewed patches have been landed. Closing bug.
Fujii Hironori
Comment 11 2019-12-17 18:48:52 PST
Committed r253669: <https://trac.webkit.org/changeset/253669>
Note You need to log in before you can comment on or make changes to this bug.