Bug 155121

Summary: Web Inspector: rename generated *EnumConversionHelpers.h to *TypeConversions.h
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, sbarati, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 155103    
Attachments:
Description Flags
Proposed Fix timothy: review+, bburg: commit-queue-

Description BJ Burg 2016-03-07 10:40:15 PST
In 155103, we'll add a *TypeConversions.mm file, so change the enum type conversions to match this naming.
Comment 1 Radar WebKit Bug Importer 2016-03-07 10:41:38 PST
<rdar://problem/25010391>
Comment 2 BJ Burg 2016-03-07 10:44:52 PST
Created attachment 273195 [details]
Proposed Fix
Comment 3 BJ Burg 2016-03-07 10:46:08 PST
Comment on attachment 273195 [details]
Proposed Fix

Needs to coordinate with internal change.
Comment 4 WebKit Commit Bot 2016-03-07 10:47:17 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 5 WebKit Commit Bot 2016-03-07 10:47:25 PST
Attachment 273195 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:52:  [ObjCFrontendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'protocol_name' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:58:  whitespace before ']'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:51:  [ObjCProtocolTypeConversionsHeaderGenerator.output_filename] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'protocol_name' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:54:  [ObjCProtocolTypeConversionsHeaderGenerator.domains_to_generate] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:67:  [ObjCProtocolTypeConversionsHeaderGenerator.generate_output] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:109:  [ObjCProtocolTypeConversionsHeaderGenerator._generate_anonymous_enum_conversion_for_declaration] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'objc_enum_name_for_anonymous_enum_declaration' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:117:  [ObjCProtocolTypeConversionsHeaderGenerator._generate_anonymous_enum_conversion_for_member] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'objc_enum_name_for_anonymous_enum_member' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:125:  [ObjCProtocolTypeConversionsHeaderGenerator._generate_anonymous_enum_conversion_for_parameter] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'objc_enum_name_for_anonymous_enum_parameter' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:58:  [ObjCProtocolTypesImplementationGenerator.generate_output] Instance of 'ObjCProtocolTypesImplementationGenerator' has no 'protocol_name' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:55:  [ObjCConfigurationImplementationGenerator.generate_output] Instance of 'ObjCConfigurationImplementationGenerator' has no 'protocol_name' member  [pylint/E1101] [5]
Total errors found: 10 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 BJ Burg 2016-03-07 13:22:37 PST
Committed r197701: <http://trac.webkit.org/changeset/197701>