Bug 155106

Summary: Make RenderStyle copy-on-write a bit less.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, simon.fraser
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2016-03-07 02:08:05 PST
The SET_VAR macro doesn't handle nested substructures well, and there are a bunch of call sites that call DataRef::access() on a container substructure, possibly causing it to detach even though the leaf value is not actually changing.
Attachments
Patch (20.51 KB, patch)
2016-03-07 02:09 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2016-03-07 02:09:46 PST
Created attachment 273167 [details] Patch
WebKit Commit Bot
Comment 2 2016-03-07 02:11:21 PST
Attachment 273167 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/style/RenderStyle.h:1503: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/rendering/style/RenderStyle.h:1504: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] ERROR: Source/WebCore/rendering/style/RenderStyle.h:1505: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2016-03-07 06:28:24 PST
Comment on attachment 273167 [details] Patch nice, r=me
WebKit Commit Bot
Comment 4 2016-03-07 07:22:17 PST
Comment on attachment 273167 [details] Patch Clearing flags on attachment: 273167 Committed r197680: <http://trac.webkit.org/changeset/197680>
WebKit Commit Bot
Comment 5 2016-03-07 07:22:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.