Bug 155103

Summary:

Web Inspector: the protocol generator should generate factory method stubs for protocol types

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

155121

Bug Blocks:

Attachments:

Description	Flags
Proposed Fix	timothy: review+

Blaze Burg

Reported 2016-03-06 23:31:47 PST

To support dynamic protocol type resolution and parsing.

Attachments
Proposed Fix (70.52 KB, patch) 2016-03-07 15:19 PST, Blaze Burg	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-03-06 23:33:31 PST

<rdar://problem/25002772>

Blaze Burg

Comment 2 2016-03-07 15:19:16 PST

Created attachment 273226 [details] Proposed Fix

WebKit Commit Bot

Comment 3 2016-03-07 15:21:06 PST

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

WebKit Commit Bot

Comment 4 2016-03-07 15:21:13 PST

Attachment 273226 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:58: [ObjCProtocolTypeConversionsHeaderGenerator.generate_output] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:50: [ObjCProtocolTypeConversionsImplementationGenerator.output_filename] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:53: [ObjCProtocolTypeConversionsImplementationGenerator.domains_to_generate] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:57: [ObjCProtocolTypeConversionsImplementationGenerator.generate_output] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:59: [ObjCProtocolTypeConversionsImplementationGenerator.generate_output] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:64: [ObjCProtocolTypeConversionsImplementationGenerator.generate_output] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:70: [ObjCProtocolTypeConversionsImplementationGenerator.generate_output] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'generate_license' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:79: [ObjCProtocolTypeConversionsImplementationGenerator._generate_type_factory_category_interface] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:93: [ObjCProtocolTypeConversionsImplementationGenerator._generate_type_factory_method_declaration] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'objc_class_for_type' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:100: [ObjCProtocolTypeConversionsImplementationGenerator._generate_type_factory_category_implementation] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:115: [ObjCProtocolTypeConversionsImplementationGenerator._generate_type_factory_method_implementation] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'objc_class_for_type' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:124: [ObjCProtocolTypeConversionsImplementationGenerator._generate_type_factory_method_implementation] Instance of 'ObjCProtocolTypeConversionsImplementationGenerator' has no 'objc_name_for_type' member [pylint/E1101] [5] Total errors found: 12 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Blaze Burg

Comment 5 2016-03-07 16:49:16 PST

Committed r197717: <http://trac.webkit.org/changeset/197717>

Note You need to log in before you can comment on or make changes to this bug.