Reduce page cache capacity from 3 to 2.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Andreas Kling]

Reducing page cache capacity is very effective at reducing heap fragmentation on iOS.

[Andreas Kling]

Created attachment 273134 [details]
Patch

[Antti Koivisto]

Comment on attachment 273134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273134&action=review

> Source/WebKit2/Shared/CacheModel.cpp:68
>          // Page cache capacity (in pages)
> -        if (memorySize >= 1024)
> -            pageCacheCapacity = 3;
> -        else if (memorySize >= 512)
> +        if (memorySize >= 512)
>              pageCacheCapacity = 2;
>          else if (memorySize >= 256)
>              pageCacheCapacity = 1;

Is ToT WebKit used on devices will less than 512MB of RAM? Can all of this be replaced with "pageCacheSize = 2"

[Andreas Kling]

(In reply to comment #2)
> Comment on attachment 273134 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273134&action=review
> 
> > Source/WebKit2/Shared/CacheModel.cpp:68
> >          // Page cache capacity (in pages)
> > -        if (memorySize >= 1024)
> > -            pageCacheCapacity = 3;
> > -        else if (memorySize >= 512)
> > +        if (memorySize >= 512)
> >              pageCacheCapacity = 2;
> >          else if (memorySize >= 256)
> >              pageCacheCapacity = 1;
> 
> Is ToT WebKit used on devices will less than 512MB of RAM? Can all of this
> be replaced with "pageCacheSize = 2"

:|

[Andreas Kling]

Let's leave that logic in there for now, since we still have other ports that run on more constrained systems.

[WebKit Commit Bot]

Comment on attachment 273134 [details]
Patch

Clearing flags on attachment: 273134

Committed r197638: <http://trac.webkit.org/changeset/197638>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

While I can understand the appeal on iOS, isn't this overly aggressive on OS X? We have data showing that navigating 3 hops back is not that uncommmon.