Bug 155082

Summary: [JSC] Use 3 operands Add in more places
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Benjamin Poulain 2016-03-05 18:58:13 PST
[JSC] Use 3 operands Add in more places
Comment 1 Benjamin Poulain 2016-03-05 19:00:23 PST
Created attachment 273118 [details]
Patch
Comment 2 Benjamin Poulain 2016-03-05 19:32:41 PST
x86:

                                                  Conf#1                    Conf#2                                      
SunSpider:
   3d-cube                                    4.8565+-0.1054            4.7649+-0.0343          might be 1.0192x faster
   3d-morph                                   5.2949+-0.0228     ?      5.3558+-0.1184        ? might be 1.0115x slower
   3d-raytrace                                5.6507+-0.0673     ?      5.6962+-0.0559        ?
   access-binary-trees                        2.2026+-0.0428     ?      2.2451+-0.0848        ? might be 1.0193x slower
   access-fannkuch                            6.1582+-0.1665            6.1040+-0.0823        
   access-nbody                               2.6902+-0.0648            2.6790+-0.0325        
   access-nsieve                              3.0056+-0.0211     ?      3.0256+-0.0278        ?
   bitops-3bit-bits-in-byte                   1.1896+-0.0155            1.1806+-0.0149        
   bitops-bits-in-byte                        3.3525+-0.0838     ?      3.3542+-0.0923        ?
   bitops-bitwise-and                         2.0655+-0.0678            2.0614+-0.0274        
   bitops-nsieve-bits                         3.0312+-0.0174            3.0212+-0.0248        
   controlflow-recursive                      2.3650+-0.0157     ?      2.3735+-0.0086        ?
   crypto-aes                                 4.0475+-0.0491     ?      4.0796+-0.0887        ?
   crypto-md5                                 2.6558+-0.0823     ?      2.7056+-0.1262        ? might be 1.0187x slower
   crypto-sha1                                2.3829+-0.0744     ?      2.3833+-0.0340        ?
   date-format-tofte                          6.9130+-0.1691            6.7964+-0.0647          might be 1.0172x faster
   date-format-xparb                          4.8159+-0.0462     ?      5.0842+-0.3729        ? might be 1.0557x slower
   math-cordic                                2.9996+-0.1141            2.9529+-0.0511          might be 1.0158x faster
   math-partial-sums                          4.9105+-0.0616     ?      4.9621+-0.2649        ? might be 1.0105x slower
   math-spectral-norm                         2.0409+-0.0109            2.0386+-0.0122        
   regexp-dna                                 6.1296+-0.1849            6.0909+-0.0981        
   string-base64                              4.6202+-0.1398            4.5647+-0.1248          might be 1.0121x faster
   string-fasta                               6.0129+-0.1825            5.9083+-0.0339          might be 1.0177x faster
   string-tagcloud                            8.1510+-0.0846     ?      8.2166+-0.1277        ?
   string-unpack-code                        19.2528+-0.4838     ?     19.6053+-0.8519        ? might be 1.0183x slower
   string-validate-input                      4.2833+-0.0659     ?      4.3095+-0.1396        ?

   <arithmetic>                               4.6569+-0.0293     ?      4.6754+-0.0477        ? might be 1.0040x slower

                                                  Conf#1                    Conf#2                                      
Octane:
   encrypt                                   0.15959+-0.00206    ?     0.16058+-0.00175       ?
   decrypt                                   2.85626+-0.01421          2.84784+-0.01202       
   deltablue                        x2       0.13937+-0.00392          0.13854+-0.00453       
   earley                                    0.28427+-0.00124    ?     0.28489+-0.00181       ?
   boyer                                     4.75049+-0.09477          4.74789+-0.08329       
   navier-stokes                    x2       4.96211+-0.02155          4.95081+-0.01437       
   raytrace                         x2       0.89685+-0.00308          0.89405+-0.00403       
   richards                         x2       0.08244+-0.00077          0.08197+-0.00095       
   splay                            x2       0.34867+-0.00196    ?     0.35085+-0.00317       ?
   regexp                           x2      22.67157+-0.21263    ^    22.22603+-0.21870       ^ definitely 1.0200x faster
   pdfjs                            x2      38.84948+-0.30275    ?    38.91550+-0.19899       ?
   mandreel                         x2      42.63247+-0.15035    ?    42.63537+-0.20102       ?
   gbemu                            x2      24.99310+-0.14506    ?    25.14904+-0.22503       ?
   closure                                   0.56651+-0.00241    ?     0.56983+-0.00465       ?
   jquery                                    7.43074+-0.01800    ?     7.55090+-0.15937       ? might be 1.0162x slower
   box2d                            x2       9.38837+-0.04111    ?     9.42184+-0.06384       ?
   zlib                             x2     388.85063+-4.62770        386.00633+-3.43741       
   typescript                       x2     662.35103+-6.63604    ?   664.68791+-6.41935       ?

   <geometric>                               5.25853+-0.01215          5.25499+-0.01727         might be 1.0007x faster

                                                  Conf#1                    Conf#2                                      
Kraken:
   ai-astar                                   98.004+-1.263             97.113+-1.792         
   audio-beat-detection                       47.988+-0.857             47.748+-0.393         
   audio-dft                                  97.914+-1.436             97.356+-1.169         
   audio-fft                                  35.840+-0.068      ?      36.386+-0.758         ? might be 1.0152x slower
   audio-oscillator                           49.178+-0.958             48.807+-0.240         
   imaging-darkroom                           60.194+-0.113      ?      60.406+-0.193         ?
   imaging-desaturate                         44.472+-0.164      ?      44.682+-0.318         ?
   imaging-gaussian-blur                      68.589+-0.320             67.566+-1.830           might be 1.0151x faster
   json-parse-financial                       37.529+-0.187      ?      38.300+-0.811         ? might be 1.0205x slower
   json-stringify-tinderbox                   25.804+-0.860             25.743+-0.796         
   stanford-crypto-aes                        39.990+-0.280             39.852+-0.314         
   stanford-crypto-ccm                        36.411+-0.533      ?      36.497+-0.941         ?
   stanford-crypto-pbkdf2                    101.709+-1.597      ?     101.789+-1.078         ?
   stanford-crypto-sha256-iterative           38.865+-0.148      ?      39.415+-1.628         ? might be 1.0142x slower

   <arithmetic>                               55.892+-0.217             55.833+-0.283           might be 1.0011x faster

                                                  Conf#1                    Conf#2                                      
AsmBench:
   bigfib.cpp                               443.8698+-7.0927          435.0971+-4.6131          might be 1.0202x faster
   cray.c                                   368.3132+-2.5795          363.6219+-2.3141          might be 1.0129x faster
   dry.c                                    443.5432+-33.7685         438.4531+-26.9264         might be 1.0116x faster
   FloatMM.c                                710.8737+-4.5558          709.4591+-2.7929        
   gcc-loops.cpp                           3672.1015+-10.2284    ?   3695.0366+-30.7866       ?
   n-body.c                                 811.2189+-3.0118     ?    812.7820+-2.5433        ?
   Quicksort.c                              396.0299+-1.9691     ?    398.9930+-9.2334        ?
   stepanov_container.cpp                  3306.4433+-19.4911    ?   3309.1160+-12.3462       ?
   Towers.c                                 269.8485+-1.1994          269.3368+-1.6104        

   <geometric>                              722.9525+-5.8363          720.5157+-5.1486          might be 1.0034x faster

                                                  Conf#1                    Conf#2                                      
Geomean of preferred means:
   <scaled-result>                           31.5387+-0.0953           31.5293+-0.1230          might be 1.0003x faster
Comment 3 WebKit Commit Bot 2016-03-06 18:42:33 PST
Comment on attachment 273118 [details]
Patch

Clearing flags on attachment: 273118

Committed r197653: <http://trac.webkit.org/changeset/197653>
Comment 4 WebKit Commit Bot 2016-03-06 18:42:36 PST
All reviewed patches have been landed.  Closing bug.