Summary: | Add support for processing the autofill field name out of form control elements ultimately to aid input methods | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, ryanhaddad | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=155115 | ||||||
Bug Depends on: | 155083 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Sam Weinig
2016-03-05 17:40:42 PST
Created attachment 273114 [details]
Patch
Attachment 273114 [details] did not pass style-queue:
ERROR: Source/WebCore/html/Autofill.cpp:55: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:56: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:57: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:58: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:59: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:60: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:61: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:62: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:63: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:64: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:65: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:66: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:67: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:68: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:69: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:70: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:71: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:72: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:73: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:74: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:75: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:76: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:77: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:78: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:79: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:80: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:81: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:82: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:83: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:84: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:85: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:86: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:87: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:88: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:89: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:90: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:91: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:92: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:93: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:94: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:95: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:96: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:97: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:98: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:99: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:101: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:102: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:103: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:104: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:105: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:106: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:107: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:108: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:109: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:110: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/html/Autofill.cpp:237: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/Autofill.cpp:260: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/Autofill.cpp:285: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/Autofill.cpp:293: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/Autofill.h:82: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 60 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
This broke several tests: fast/forms/autocomplete.html imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete.html inspector/model/remote-object.html Rolling out. In the future, please wait for EWS before landing. Re-opened since this is blocked by bug 155083 Sam is actively working on this, and asked to not roll out. Additional fix in revision 197629. Additional test fixes in revision 197631 inspector/model/remote-object.html is sill failing on all bots. It has somewhat checkered recent history, however it seems clearly related to this change. @@ -1919,7 +1919,7 @@ "_listeners": null, "_name": "autocomplete", "_type": "string", - "_value": "on" + "_value": "" }, { "_listeners": null, (In reply to comment #9) > inspector/model/remote-object.html is sill failing on all bots. It has > somewhat checkered recent history, however it seems clearly related to this > change. > > @@ -1919,7 +1919,7 @@ > "_listeners": null, > "_name": "autocomplete", > "_type": "string", > - "_value": "on" > + "_value": "" > }, > { > "_listeners": null, Filed https://bugs.webkit.org/show_bug.cgi?id=155115 to track. |