Bug 155071

Summary:

[JSC] Remove a useless "Move" from baseline-JIT op_mul's fast path

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Benjamin Poulain

Reported 2016-03-05 15:16:46 PST

[JSC] Remove a useless "Move" from baseline-JIT op_mul's fast path

Attachments
Patch (2.80 KB, patch) 2016-03-05 15:17 PST, Benjamin Poulain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2016-03-05 15:17:56 PST

Created attachment 273101 [details] Patch

Benjamin Poulain

Comment 2 2016-03-05 15:19:30 PST

Useful for Sunspider. I doubt that will help any other benchmark: Conf#1 Conf#2 3d-cube 4.8120+-0.0615 ? 4.8620+-0.1448 ? might be 1.0104x slower 3d-morph 5.4550+-0.1999 5.3248+-0.0256 might be 1.0245x faster 3d-raytrace 5.6889+-0.0605 ? 5.7573+-0.0993 ? might be 1.0120x slower access-binary-trees 2.2023+-0.0702 ? 2.2791+-0.1373 ? might be 1.0348x slower access-fannkuch 6.0842+-0.1919 ? 6.2618+-0.3064 ? might be 1.0292x slower access-nbody 2.7319+-0.0712 2.7156+-0.0459 access-nsieve 3.0611+-0.0894 3.0315+-0.0712 bitops-3bit-bits-in-byte 1.1824+-0.0228 ? 1.1891+-0.0258 ? bitops-bits-in-byte 3.3129+-0.0350 ? 3.3498+-0.0505 ? might be 1.0111x slower bitops-bitwise-and 2.1524+-0.0938 2.1421+-0.0922 bitops-nsieve-bits 3.1258+-0.1240 3.0624+-0.0383 might be 1.0207x faster controlflow-recursive 2.3898+-0.0535 ? 2.3947+-0.0497 ? crypto-aes 4.0141+-0.0312 ? 4.0504+-0.0387 ? crypto-md5 2.5760+-0.0188 ? 2.6217+-0.0555 ? might be 1.0178x slower crypto-sha1 2.3456+-0.0369 2.3417+-0.0114 date-format-tofte 6.8730+-0.0833 ? 6.9368+-0.1232 ? date-format-xparb 4.8472+-0.0824 ? 4.9277+-0.1234 ? might be 1.0166x slower math-cordic 3.0174+-0.0999 ? 3.0407+-0.1887 ? math-partial-sums 5.0294+-0.1186 4.9583+-0.1085 might be 1.0143x faster math-spectral-norm 2.0405+-0.0270 ? 2.0534+-0.0375 ? regexp-dna 6.5270+-0.4192 6.1059+-0.1505 might be 1.0690x faster string-base64 4.6023+-0.1701 4.5483+-0.0740 might be 1.0119x faster string-fasta 5.9656+-0.0696 ? 6.0196+-0.2774 ? string-tagcloud 8.4972+-0.2720 8.3649+-0.2489 might be 1.0158x faster string-unpack-code 18.8633+-0.6859 18.5759+-0.2329 might be 1.0155x faster string-validate-input 4.2562+-0.1027 ? 4.2848+-0.0806 ? <arithmetic> 4.6790+-0.0256 4.6616+-0.0305 might be 1.0037x faster

Geoffrey Garen

Comment 3 2016-03-07 09:29:40 PST

Comment on attachment 273101 [details] Patch r=me

WebKit Commit Bot

Comment 4 2016-03-07 10:23:36 PST

Comment on attachment 273101 [details] Patch Clearing flags on attachment: 273101 Committed r197685: <http://trac.webkit.org/changeset/197685>

WebKit Commit Bot

Comment 5 2016-03-07 10:23:40 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.