Bug 155062

Summary: Add the support for upgrading custom elements in cloneNode
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Adds the support
none
Minor fix in change log
none
Fix GTK/EFL builds
none
Patch for landing none

Description Ryosuke Niwa 2016-03-05 00:36:44 PST
Node.prototype.cloneNode should support upgrading custom elements.
Comment 1 Ryosuke Niwa 2016-03-05 00:37:12 PST
<rdar://problem/24949463>
Comment 2 Ryosuke Niwa 2016-03-05 01:08:08 PST
Created attachment 273072 [details]
Adds the support
Comment 3 Ryosuke Niwa 2016-03-05 01:08:59 PST
Created attachment 273073 [details]
Minor fix in change log
Comment 4 Ryosuke Niwa 2016-03-05 01:12:07 PST
Created attachment 273075 [details]
Fix GTK/EFL builds
Comment 5 Antti Koivisto 2016-03-05 01:15:08 PST
Comment on attachment 273075 [details]
Fix GTK/EFL builds

View in context: https://bugs.webkit.org/attachment.cgi?id=273075&action=review

> Source/WebCore/dom/LifecycleCallbackQueue.cpp:51
> +        , m_attributeName(nullQName())

This isn't needed.
Comment 6 Ryosuke Niwa 2016-03-05 01:18:06 PST
(In reply to comment #5)
> Comment on attachment 273075 [details]
> Fix GTK/EFL builds
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273075&action=review
> 
> > Source/WebCore/dom/LifecycleCallbackQueue.cpp:51
> > +        , m_attributeName(nullQName())
> 
> This isn't needed.

Actually, it's needed on Mac port :(  Compiler will complain otherwise.  I guess QNAME_DEFAULT_CONSTRUCTOR is false at
http://trac.webkit.org/browser/trunk/Source/WebCore/dom/QualifiedName.h#L76

#ifdef QNAME_DEFAULT_CONSTRUCTOR
    QualifiedName() { }
#endif
Comment 7 Ryosuke Niwa 2016-03-05 01:27:00 PST
I'm going to use Optional<QualifiedName> instead as discussed on IRC.
Comment 8 Ryosuke Niwa 2016-03-05 01:27:32 PST
Created attachment 273078 [details]
Patch for landing
Comment 9 Ryosuke Niwa 2016-03-05 01:27:47 PST
Comment on attachment 273078 [details]
Patch for landing

Wait for EWS first.
Comment 10 Ryosuke Niwa 2016-03-05 21:07:35 PST
Committed r197634: <http://trac.webkit.org/changeset/197634>