Summary: | Add the support for upgrading custom elements in cloneNode | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 154907 | ||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2016-03-05 00:36:44 PST
Created attachment 273072 [details]
Adds the support
Created attachment 273073 [details]
Minor fix in change log
Created attachment 273075 [details]
Fix GTK/EFL builds
Comment on attachment 273075 [details] Fix GTK/EFL builds View in context: https://bugs.webkit.org/attachment.cgi?id=273075&action=review > Source/WebCore/dom/LifecycleCallbackQueue.cpp:51 > + , m_attributeName(nullQName()) This isn't needed. (In reply to comment #5) > Comment on attachment 273075 [details] > Fix GTK/EFL builds > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273075&action=review > > > Source/WebCore/dom/LifecycleCallbackQueue.cpp:51 > > + , m_attributeName(nullQName()) > > This isn't needed. Actually, it's needed on Mac port :( Compiler will complain otherwise. I guess QNAME_DEFAULT_CONSTRUCTOR is false at http://trac.webkit.org/browser/trunk/Source/WebCore/dom/QualifiedName.h#L76 #ifdef QNAME_DEFAULT_CONSTRUCTOR QualifiedName() { } #endif I'm going to use Optional<QualifiedName> instead as discussed on IRC. Created attachment 273078 [details]
Patch for landing
Comment on attachment 273078 [details]
Patch for landing
Wait for EWS first.
Committed r197634: <http://trac.webkit.org/changeset/197634> |