Bug 155031 – Unify determination of page timer alignment

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Gavin Barraclough]

Currently this is scattered throughout Page - sites that call setDOMTimerAlignmentInterval have to determine the correct alignment interval.

Instead, replace setDOMTimerAlignmentInterval with updateDOMTimerAlignmentInterval, and unify the policy decision here.

[Gavin Barraclough]

Created attachment 273024 [details]
Fix

[Chris Dumez]

Comment on attachment 273024 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273024&action=review

r=me

> Source/WebCore/page/Page.cpp:1260
> +    else if (!m_timerAlignmentIntervalIncreaseTimer.isActive())

This is not new but is it possible for m_timerAlignmentInterval to change and for the timer to be active? If so, we currently fail to update the timer. I am guessing we may be working around this by disabling and then re-enabling throttling but if so, it is not very nice.

[Gavin Barraclough]

(In reply to comment #2)
> Comment on attachment 273024 [details]
>
> This is not new but is it possible for m_timerAlignmentInterval to change
> and for the timer to be active? If so, we currently fail to update the
> timer. I am guessing we may be working around this by disabling and then
> re-enabling throttling but if so, it is not very nice.

Per conversation with Chris, this is a deliberate part of the policy, as a simple solution to prevent timers from being pushed out infinitely.

[Gavin Barraclough]

Transmitting file data ...
Committed revision 197581.