Bug 155029

Summary: Blur filter escapes an enclosing overflow:hidden
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, kondapallykalyan, krit, sabouhallawa, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://stripe.com/atlas
Attachments:
Description Flags
Patch
none
Patch zalan: review+

Simon Fraser (smfr)
Reported 2016-03-04 11:38:57 PST
https://jsfiddle.net/1edf4k9t/4/ shows a bug where a blur filter escapes an enclosing overflow:hidden
Attachments
Patch (21.21 KB, patch)
2016-04-29 19:42 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (21.14 KB, patch)
2016-04-29 19:56 PDT, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-03-05 17:44:21 PST
The clipping that RenderLayer::applyFilters() does is all wrong. The current code happens to never clip, because inside clipToRect(), clipRect.rect() == paintingInfo.paintDirtyRect. However, fixing that breaks filters that draw outside their bounds (blur, drop-shadow) because the backgroundRect used to clip is the pre-filtered background rect, taken from the paintDirtyRect.
Simon Fraser (smfr)
Comment 2 2016-04-01 10:53:44 PDT
rdar://problem/25488747
Simon Fraser (smfr)
Comment 3 2016-04-29 19:42:18 PDT
Created attachment 277783 [details] Patch
Simon Fraser (smfr)
Comment 4 2016-04-29 19:56:38 PDT
Created attachment 277784 [details] Patch
Simon Fraser (smfr)
Comment 5 2016-04-29 21:13:28 PDT
https://trac.webkit.org/r200283
Note You need to log in before you can comment on or make changes to this bug.