Bug 155024

Summary:

[ES6] Implement Reflect.set without receiver support

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cgarcia, commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

155294

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ggaren: review+

Yusuke Suzuki

Reported 2016-03-04 10:12:51 PST

[ES6] Implement Reflect.set

Attachments
Patch (132.74 KB, patch) 2016-03-04 10:14 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (135.11 KB, patch) 2016-03-04 10:34 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (185.45 KB, patch) 2016-03-04 11:53 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (185.56 KB, patch) 2016-03-04 12:03 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (187.01 KB, patch) 2016-03-05 09:49 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (358.73 KB, patch) 2016-03-05 12:25 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (358.87 KB, patch) 2016-03-06 05:10 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (407.42 KB, patch) 2016-03-06 09:49 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (405.94 KB, patch) 2016-03-11 02:59 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (406.03 KB, patch) 2016-03-11 03:07 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (406.67 KB, patch) 2016-03-11 03:22 PST, Yusuke Suzuki	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2016-03-04 10:14:32 PST

Created attachment 273011 [details] Patch WIP

Yusuke Suzuki

Comment 2 2016-03-04 10:34:27 PST

Created attachment 273016 [details] Patch WIP part2

Yusuke Suzuki

Comment 3 2016-03-04 11:53:45 PST

Created attachment 273020 [details] Patch WIP part3

Yusuke Suzuki

Comment 4 2016-03-04 12:03:08 PST

Created attachment 273021 [details] Patch WIP part4

WebKit Commit Bot

Comment 5 2016-03-04 12:06:12 PST

Attachment 273021 [details] did not pass style-queue: ERROR: Source/WebCore/bridge/objc/objc_runtime.h:81: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/bridge/objc/objc_runtime.h:82: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/bridge/objc/objc_runtime.mm:157: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 3 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 6 2016-03-05 09:49:36 PST

Created attachment 273089 [details] Patch WIP part5

Yusuke Suzuki

Comment 7 2016-03-05 12:25:34 PST

Created attachment 273091 [details] Patch WIP part6

WebKit Commit Bot

Comment 8 2016-03-05 12:36:52 PST

Attachment 273091 [details] did not pass style-queue: ERROR: Source/WebCore/bridge/objc/objc_runtime.h:81: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/bridge/objc/objc_runtime.h:82: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/bridge/objc/objc_runtime.mm:157: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 3 in 116 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 9 2016-03-06 05:10:32 PST

Created attachment 273135 [details] Patch WIP part7

WebKit Commit Bot

Comment 10 2016-03-06 05:14:55 PST

Attachment 273135 [details] did not pass style-queue: ERROR: Source/WebCore/bridge/objc/objc_runtime.h:81: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/bridge/objc/objc_runtime.h:82: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/bridge/objc/objc_runtime.mm:157: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 3 in 116 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 11 2016-03-06 09:49:38 PST

Created attachment 273138 [details] Patch WIP part9

Yusuke Suzuki

Comment 12 2016-03-11 02:59:51 PST

Created attachment 273715 [details] Patch

Yusuke Suzuki

Comment 13 2016-03-11 03:07:01 PST

Created attachment 273716 [details] Patch Rebased

WebKit Commit Bot

Comment 14 2016-03-11 03:09:33 PST

Attachment 273716 [details] did not pass style-queue: ERROR: Source/WebCore/bridge/objc/objc_runtime.h:81: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/bridge/objc/objc_runtime.h:82: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/bridge/objc/objc_runtime.mm:157: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 3 in 120 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 15 2016-03-11 03:22:25 PST

Created attachment 273717 [details] Patch Rebased part2

WebKit Commit Bot

Comment 16 2016-03-11 03:24:40 PST

Attachment 273717 [details] did not pass style-queue: ERROR: Source/WebCore/bridge/objc/objc_runtime.h:81: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/bridge/objc/objc_runtime.h:82: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/bridge/objc/objc_runtime.mm:157: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 3 in 120 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 17 2016-03-11 09:13:49 PST

Comment on attachment 273717 [details] Patch r=me

Yusuke Suzuki

Comment 18 2016-03-11 09:17:33 PST

(In reply to comment #17) > Comment on attachment 273717 [details] > Patch > > r=me Thank you for your review :D

Yusuke Suzuki

Comment 19 2016-03-11 09:28:40 PST

Committed r198023: <http://trac.webkit.org/changeset/198023>

Yusuke Suzuki

Comment 20 2016-03-11 10:42:44 PST

Oops, I'll update the binding test results soon.

Yusuke Suzuki

Comment 21 2016-03-11 10:48:35 PST

Committed r198028: <http://trac.webkit.org/changeset/198028>

Note You need to log in before you can comment on or make changes to this bug.