Bug 155024

Summary:

[ES6] Implement Reflect.set without receiver support

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cgarcia, commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

155294

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ggaren: review+

Description Yusuke Suzuki 2016-03-04 10:12:51 PST

[ES6] Implement Reflect.set

Comment 1 Yusuke Suzuki 2016-03-04 10:14:32 PST

Created attachment 273011 [details]
Patch

WIP

Comment 2 Yusuke Suzuki 2016-03-04 10:34:27 PST

Created attachment 273016 [details]
Patch

WIP part2

Comment 3 Yusuke Suzuki 2016-03-04 11:53:45 PST

Created attachment 273020 [details]
Patch

WIP part3

Comment 4 Yusuke Suzuki 2016-03-04 12:03:08 PST

Created attachment 273021 [details]
Patch

WIP part4

Comment 5 WebKit Commit Bot 2016-03-04 12:06:12 PST

Attachment 273021 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/objc/objc_runtime.h:81:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/bridge/objc/objc_runtime.h:82:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/bridge/objc/objc_runtime.mm:157:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 3 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Yusuke Suzuki 2016-03-05 09:49:36 PST

Created attachment 273089 [details]
Patch

WIP part5

Comment 7 Yusuke Suzuki 2016-03-05 12:25:34 PST

Created attachment 273091 [details]
Patch

WIP part6

Comment 8 WebKit Commit Bot 2016-03-05 12:36:52 PST

Attachment 273091 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/objc/objc_runtime.h:81:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/bridge/objc/objc_runtime.h:82:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/bridge/objc/objc_runtime.mm:157:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 3 in 116 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Yusuke Suzuki 2016-03-06 05:10:32 PST

Created attachment 273135 [details]
Patch

WIP part7

Comment 10 WebKit Commit Bot 2016-03-06 05:14:55 PST

Attachment 273135 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/objc/objc_runtime.h:81:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/bridge/objc/objc_runtime.h:82:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/bridge/objc/objc_runtime.mm:157:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 3 in 116 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 Yusuke Suzuki 2016-03-06 09:49:38 PST

Created attachment 273138 [details]
Patch

WIP part9

Comment 12 Yusuke Suzuki 2016-03-11 02:59:51 PST

Created attachment 273715 [details]
Patch

Comment 13 Yusuke Suzuki 2016-03-11 03:07:01 PST

Created attachment 273716 [details]
Patch

Rebased

Comment 14 WebKit Commit Bot 2016-03-11 03:09:33 PST

Attachment 273716 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/objc/objc_runtime.h:81:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/bridge/objc/objc_runtime.h:82:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/bridge/objc/objc_runtime.mm:157:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 3 in 120 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 15 Yusuke Suzuki 2016-03-11 03:22:25 PST

Created attachment 273717 [details]
Patch

Rebased part2

Comment 16 WebKit Commit Bot 2016-03-11 03:24:40 PST

Attachment 273717 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/objc/objc_runtime.h:81:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/bridge/objc/objc_runtime.h:82:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/bridge/objc/objc_runtime.mm:157:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 3 in 120 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 17 Geoffrey Garen 2016-03-11 09:13:49 PST

Comment on attachment 273717 [details]
Patch

r=me

Comment 18 Yusuke Suzuki 2016-03-11 09:17:33 PST

(In reply to comment #17)
> Comment on attachment 273717 [details]
> Patch
> 
> r=me

Thank you for your review :D

Comment 19 Yusuke Suzuki 2016-03-11 09:28:40 PST

Committed r198023: <http://trac.webkit.org/changeset/198023>

Comment 20 Yusuke Suzuki 2016-03-11 10:42:44 PST

Oops, I'll update the binding test results soon.

Comment 21 Yusuke Suzuki 2016-03-11 10:48:35 PST

Committed r198028: <http://trac.webkit.org/changeset/198028>