Enable DOM class create functions to take parameters in case of JSBuiltinConstructor

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

This is needed for bug 154729

[youenn fablet]

Created attachment 273002 [details]
Patch

[youenn fablet]

Created attachment 273005 [details]
Fixing DOMWrapper::create(...) case

[Darin Adler]

Comment on attachment 273005 [details]
Fixing DOMWrapper::create(...) case

View in context: https://bugs.webkit.org/attachment.cgi?id=273005&action=review

> Source/WebCore/bindings/js/JSDOMConstructor.h:125
> +    JSC::EncodedJSValue callConstructor(JSC::ExecState&, JSC::JSObject&);
> +    JSC::EncodedJSValue callConstructor(JSC::ExecState&, JSC::JSObject*);
>      // Usually defined for each specialization class.

I don’t think these two should be grouped with the comment below. Consider adding a blank line.

> Source/WebCore/bindings/js/JSDOMConstructor.h:261
> +    ASSERT(castedThis);

Not sure this assertion is valuable.

> Source/WebCore/bindings/js/JSDOMWrapper.h:83
> +    template<typename T>
> +    static constexpr auto test(int) -> decltype(T::create(), bool()) { return true; }
> +    template<typename T>
> +    static constexpr bool test(...) { return false; }

I think the would read better as one liners instead of split into two lines.

[youenn fablet]

Created attachment 273137 [details]
Patch for landing

[youenn fablet]

Thanks for the review.
Landing patch uploaded according comments.

[WebKit Commit Bot]

Comment on attachment 273137 [details]
Patch for landing

Clearing flags on attachment: 273137

Committed r197642: <http://trac.webkit.org/changeset/197642>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.