Summary: | Added missing override specifiers under Source/WebCore. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Konstantin Tokarev <annulen> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, darin, mcatanzaro | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Konstantin Tokarev
2016-03-04 08:55:01 PST
Also added #if(SOUP) guard to ResourceHandleStreamingClient::getOrCreateReadBuffer because it is not an overridden method otherwise. Created attachment 272981 [details]
Patch
Comment on attachment 272981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272981&action=review Neat! > Source/WebCore/page/DebugPageOverlays.cpp:62 > + void pageOverlayDestroyed(PageOverlay&) final; > + void willMoveToPage(PageOverlay&, Page*) final; > + void didMoveToPage(PageOverlay&, Page*) final; > + void drawRect(PageOverlay&, GraphicsContext&, const IntRect& dirtyRect) final; > + bool mouseEvent(PageOverlay&, const PlatformMouseEvent&) final; > + void didScrollFrame(PageOverlay&, Frame&) final; Looks wrong. We removed virtual here but did not add override. Maybe a bug in the tool. Comment on attachment 272981 [details] Patch Rejecting attachment 272981 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 272981, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 197565 = 1a4d6f9449d5b75e25c145f5a1f6efa1363823f8 r197566 = 49cc03e4bf77a42908478cfbda938088cf1a8567 r197567 = af1f071f0d7cca1b5b368272929370991d9a6402 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/922791 Created attachment 273014 [details]
Patch
Comment on attachment 273014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273014&action=review Amazing there are so few instances of this to change > Source/WebCore/ChangeLog:18 > + * page/DebugPageOverlays.cpp: Got to remove this from the changelog. The change to DebugPageOverlays.cpp was good, by the way; as discussed elsewhere, override and final are redundant. But I agree it doesn't need to be part of this patch. Comment on attachment 273014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273014&action=review >> Source/WebCore/ChangeLog:18 >> + * page/DebugPageOverlays.cpp: > > Got to remove this from the changelog. > > The change to DebugPageOverlays.cpp was good, by the way; as discussed elsewhere, override and final are redundant. But I agree it doesn't need to be part of this patch. That changes just disappeared when I rebased it on top of Darin's patch :) Created attachment 273030 [details]
Patch
(In reply to comment #6) > Comment on attachment 273014 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273014&action=review > > Amazing there are so few instances of this to change zandobersek have done a series of similar patches before, you can find them by words "missing override specifiers". Maybe we need to enforce policy with appropriate Werror. (In reply to comment #9) > zandobersek have done a series of similar patches before, you can find them > by words "missing override specifiers". Maybe we need to enforce policy with > appropriate Werror. Bug #155049 Comment on attachment 273030 [details] Patch Clearing flags on attachment: 273030 Committed r197591: <http://trac.webkit.org/changeset/197591> All reviewed patches have been landed. Closing bug. |