Bug 155002

Summary: [[GetPrototypeOf]] should be a fully virtual method in the method table
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 161534, 155097    
Bug Blocks:    
Attachments:
Description Flags
patch
fpizlo: review+
perf numbers
none
patch for landing
none
patch for landing v2
none
v3
none
v4 none

Saam Barati
Reported 2016-03-03 19:20:54 PST
This is needed for Proxy. To make things fast, we will probably have to change some JIT code to respect this and to introduce a getPrototypeInline which will try to perform the default getPrototype which will probably be named getPrototypeDirect.
Attachments
patch (59.30 KB, patch)
2016-03-05 15:31 PST, Saam Barati 		fpizlo: review+
DetailsFormatted DiffDiff
perf numbers (66.95 KB, text/plain)
2016-03-05 15:35 PST, Saam Barati 		no flags
Details
patch for landing (58.05 KB, patch)
2016-03-06 14:35 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing v2 (119.99 KB, patch)
2016-03-06 16:07 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
v3 (121.00 KB, patch)
2016-03-06 16:12 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
v4 (128.08 KB, patch)
2016-03-06 16:25 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-03-05 15:31:01 PST
Created attachment 273102 [details] patch
Filip Pizlo
Comment 2 2016-03-05 15:32:32 PST
Comment on attachment 273102 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=273102&action=review > Source/JavaScriptCore/dfg/DFGOperations.cpp:1392 > > +#if USE(JSVALUE64) > +EncodedJSValue > +#else > +int32_t > +#endif Yuck! Why not just return size_t like other functions that are in this situation?
Saam Barati
Comment 3 2016-03-05 15:35:19 PST
Created attachment 273104 [details] perf numbers
Saam Barati
Comment 4 2016-03-06 14:35:54 PST
Created attachment 273147 [details] patch for landing
Saam Barati
Comment 5 2016-03-06 15:14:25 PST
The compiler is confused about the ClassName::getPrototype when building the method table :(
Saam Barati
Comment 6 2016-03-06 16:07:33 PST
Created attachment 273151 [details] patch for landing v2 I want to see EWS results
Saam Barati
Comment 7 2016-03-06 16:12:08 PST
Created attachment 273152 [details] v3 more method renaming. Hopefully no more is needed.
Saam Barati
Comment 8 2016-03-06 16:25:33 PST
Created attachment 273153 [details] v4
Saam Barati
Comment 9 2016-03-06 17:00:56 PST
landed in: http://trac.webkit.org/changeset/197648
Note You need to log in before you can comment on or make changes to this bug.