Bug 155001

Summary: [iOS] Crash during font loading when injected bundle cancels load
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, jonlee, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Myles C. Maxfield 2016-03-03 18:57:54 PST
[iOS] Crash during font loading when plug in cancels load
Comment 1 Myles C. Maxfield 2016-03-03 18:59:38 PST
Created attachment 272816 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-03-03 22:39:03 PST
Comment on attachment 272816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272816&action=review

> Source/WebCore/ChangeLog:3
> +        [iOS] Crash during font loading when plug in cancels load

We call them plug-ins, but do you mean Content Blockers?
Comment 3 Tim Horton 2016-03-03 22:42:43 PST
(In reply to comment #2)
> Comment on attachment 272816 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=272816&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [iOS] Crash during font loading when plug in cancels load
> 
> We call them plug-ins, but do you mean Content Blockers?

He means injected bundles. But I doubt this is exclusive to cancellation from the bundle.
Comment 4 Myles C. Maxfield 2016-03-04 10:22:38 PST
Created attachment 273013 [details]
Patch
Comment 5 Tim Horton 2016-03-04 10:24:56 PST
Comment on attachment 273013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273013&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:47
> +@interface NavigationHandlerDelegate : NSObject <WKNavigationDelegate>

ObjC class names have to be unique across the whole project. While you got lucky here, I would put the name of your test in here ("CancelFontSubresourceNavigationDelegate")
Comment 6 Myles C. Maxfield 2016-03-04 10:30:44 PST
Committed r197570: <http://trac.webkit.org/changeset/197570>