| Summary: | Drop DocumentSharedObjectPool immediately when going into PageCache. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
| Component: | DOM | Assignee: | Andreas Kling <kling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, kangil.han | ||||
| Priority: | P2 | Keywords: | Performance | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andreas Kling
2016-03-03 15:32:20 PST
Created attachment 272780 [details]
Patch
Comment on attachment 272780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272780&action=review > Source/WebCore/dom/Document.cpp:5049 > -void Document::sharedObjectPoolClearTimerFired() > +void Document::clearSharedObjectPool() I often keep *TimerFired function that just calls a payload function. Makes it easier to see what is what. Comment on attachment 272780 [details] Patch Clearing flags on attachment: 272780 Committed r197552: <http://trac.webkit.org/changeset/197552> All reviewed patches have been landed. Closing bug. Reverted r197552 for reason: May have caused a ~2% PLT regression on iOS Committed r198500: <http://trac.webkit.org/changeset/198500> Reverted r198500 for reason: Roll back in r197552 as it did not seem to cause a PLT regression after all Committed r198658: <http://trac.webkit.org/changeset/198658> |