Bug 154954

Summary: Web Inspector: Timelines UI redesign: use DataGridNode for TimelineView selection path components
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 153036    
Attachments:
Description Flags
[Patch] Proposed Fix
none
[Patch] Proposed Fix none

Description Matt Baker 2016-03-02 21:53:44 PST 
* SUMMARY
Use DataGridNode for TimelineView selection path components. Currently GeneralTreeElementPathComponents are created from the selected tree element in the sidebar. The selected grid node should be used instead.
Comment 1 Radar WebKit Bug Importer 2016-03-02 21:53:57 PST 
<rdar://problem/24947939>
Comment 2 Matt Baker 2016-03-09 15:41:56 PST 
Created attachment 273492 [details]
[Patch] Proposed Fix
Comment 3 Timothy Hatcher 2016-03-09 15:56:48 PST 
Comment on attachment 273492 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273492&action=review

> Source/WebInspectorUI/UserInterface/Views/ProfileNodeDataGridNode.js:132
> +    // Protected

This would be public. Protected is for subclass internal use, not use from another class.
Comment 4 Matt Baker 2016-03-09 16:32:46 PST 
Comment on attachment 273492 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273492&action=review

>> Source/WebInspectorUI/UserInterface/Views/ProfileNodeDataGridNode.js:132
>> +    // Protected
> 
> This would be public. Protected is for subclass internal use, not use from another class.

TimelineDataGridNode and its other subclasses should be updated too.
Comment 5 Matt Baker 2016-03-09 16:49:56 PST 
Created attachment 273511 [details]
[Patch] Proposed Fix
Comment 6 WebKit Commit Bot 2016-03-09 17:37:52 PST 
Comment on attachment 273511 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 273511

Committed r197909: <http://trac.webkit.org/changeset/197909>
Comment 7 WebKit Commit Bot 2016-03-09 17:37:55 PST 
All reviewed patches have been landed.  Closing bug.