Bug 154926 – Add Page::TimerThrottlingState

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Gavin Barraclough]

Hidden page timer throttling is currently a boolean state, indicated by whether the Optional m_timerThrottlingEnabledTime is in a set/unset state. When enabled, the increasing mechanism may or may not be enable, this is controlled directly by the setting.

Refactor to add a enum tracking timer throttling being in one of three states - disabled, enabled, or enabled-throttling. This cleans things up, and will enabled up to introduce a dynamic policy for when enabled-throttling is enabled. (Behavior is unchanged in this patch.)

[Gavin Barraclough]

Created attachment 272670 [details]
Fix

[Chris Dumez]

Comment on attachment 272670 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=272670&action=review

r=me

> Source/WebCore/ChangeLog:10
> +        may or may not be enable, this is controlled directly by the setting.

typo: "enable"

> Source/WebCore/ChangeLog:12
> +        Refactor to add a enum tracking timer throttling being in one of three states - disabled,

Typo: "a enum"

> Source/WebCore/ChangeLog:14
> +        dynamic policy for when enabled-throttling is enabled. (Behavior is unchanged in this patch.)

"enabled-increasing" ?

> Source/WebCore/page/Page.cpp:1230
> +    double throttledDuration = monotonicallyIncreasingTime() - m_timerThrottlingEnabledTime;

We could also assert that m_timerThrottlingEnabledTime is not 0.

[Gavin Barraclough]

Transmitting file data ...
Committed revision 197459.