Bug 154901

Summary:

RegExpExec/RegExpTest should not unconditionally speculate cell

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=154575

Bug Depends on:

154927

Bug Blocks:

Attachments:

Description	Flags
work in progress	none
performance	none
the patch	none
the patch	benjamin: review+

Filip Pizlo

Reported 2016-03-01 19:36:34 PST

Patch forthcoming.

Attachments
work in progress (9.75 KB, patch) 2016-03-01 19:42 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
performance (66.10 KB, text/plain) 2016-03-02 12:11 PST, Filip Pizlo	no flags	Details
the patch (18.64 KB, patch) 2016-03-02 20:54 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (18.38 KB, patch) 2016-03-02 21:10 PST, Filip Pizlo	benjamin: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2016-03-01 19:42:59 PST

Created attachment 272626 [details] work in progress

Filip Pizlo

Comment 2 2016-03-02 12:11:03 PST

Created attachment 272672 [details] performance This performance test includes the changes to FTL OSR heuristics.

Filip Pizlo

Comment 3 2016-03-02 20:54:06 PST

Created attachment 272725 [details] the patch

Filip Pizlo

Comment 4 2016-03-02 20:55:14 PST

Comment on attachment 272725 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=272725&action=review > Source/JavaScriptCore/dfg/DFGOperations.cpp:1607 > + //dataLog("triggerOSREntryNow not neverExecutedEntry: ", *codeBlock, "\n"); I will remove this.

WebKit Commit Bot

Comment 5 2016-03-02 20:56:37 PST

Attachment 272725 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGOperations.cpp:635: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/dfg/DFGOperations.cpp:1607: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 6 2016-03-02 20:58:56 PST

I have a fix for the 32-bit build.

Filip Pizlo

Comment 7 2016-03-02 21:10:32 PST

Created attachment 272727 [details] the patch

WebKit Commit Bot

Comment 8 2016-03-02 21:11:54 PST

Attachment 272727 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGOperations.cpp:635: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Benjamin Poulain

Comment 9 2016-03-02 21:16:41 PST

Comment on attachment 272727 [details] the patch Can you please add tests for the new exception checks?

Filip Pizlo

Comment 10 2016-03-02 21:40:43 PST

(In reply to comment #9) > Comment on attachment 272727 [details] > the patch > > Can you please add tests for the new exception checks? I'll try. I think that running after the exception is observable in this case. However, I think we want to check for exceptions after every effect, even if you can't construct a test to prove that it's needed. Forgetting exception checks, or avoiding them to be clever, has caused us trouble in the past.

Filip Pizlo

Comment 11 2016-03-02 21:59:29 PST

Landed in http://trac.webkit.org/changeset/197492

Note You need to log in before you can comment on or make changes to this bug.