[GTK] Scrollbars are broken again with GTK+ >= 3.19.11

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Hussam Al-Tayeb]

Created attachment 272603 [details]
unfocused scrollbar

I think they tweeked theming a bit in gtk post 3.19.10 release so webkitgtk+ has to adjust?

[Hussam Al-Tayeb]

Created attachment 272604 [details]
focused scrollbar

[Hussam Al-Tayeb]

Normal gtk+ applications still show normally sized scrollbars. Only webkitgtk+ implementation is affected.

[Michael Catanzaro]

Probably due to https://git.gnome.org/browse/gtk+/commit/?id=f0d9afd3005206dfe0962965a2fa21baf9e1fa97

[Carlos Garcia Campos]

Yes, hopefully after 3.20 we don't need to adjust our theme code for every single GTK+ commit :-(

[Carlos Garcia Campos]

Renaming since this is not specific to overlay scrollbars not 2.11.91 version, it was GTK+ what broke us again, deprecating style properties that are now ignored by GTK+.

[Carlos Garcia Campos]

Created attachment 272846 [details]
Patch

After two days fighting with this, I've finally managed to get something that keeps the exactly same behavior with previous version of GTK+ (at least the GTK+ version we have in out internal jhbuild which is the one I've tried), and matches exactly what GTK+ from today git master does. I can't promise it will work tomorrow, though.

[Michael Catanzaro]

See what thou hast wrought.

[Michael Catanzaro]

Comment on attachment 272846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272846&action=review

> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:138
> +    GtkBorder stepperSpacing = { 0, 0, 0, 0};

0 };

> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:296
> +        return IntRect(trackRect.x() + thumbPos, trackRect.y() + troughBorder.top + (trackRect.height() - thumbFat) / 2, thumbLength(scrollbar), thumbFat);

I don't see how this works in older GTK+.

[Carlos Garcia Campos]

Comment on attachment 272846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272846&action=review

>> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:296
>> +        return IntRect(trackRect.x() + thumbPos, trackRect.y() + troughBorder.top + (trackRect.height() - thumbFat) / 2, thumbLength(scrollbar), thumbFat);
> 
> I don't see how this works in older GTK+.

See the #if above, in older GTK+ troughBorder is 0, so this doesn't have any new effect. As I said I tried with GTK+ 3.16 compiled in our jhbuild.

[Carlos Garcia Campos]

Committed r197609: <http://trac.webkit.org/changeset/197609>