Summary: | SIGSEGV in Proxy [[Get]] and [[Set]] recursion | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | André Bargull <andre.bargull> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, saam, sukolsak, ysuzuki | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
André Bargull
2016-03-01 04:06:23 PST
Thanks for reporting this. So it seems like recursion is the correct behavior here. We just need to detect when we've recursed too far and throw a stack overflow error. Created attachment 272639 [details]
patch
Comment on attachment 272639 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=272639&action=review Interesting, nice catch! r=me > Source/JavaScriptCore/tests/stress/proxy-get-and-set-recursion-stack-overflow.js:18 > +} I suggest adding indexed get case. landed in: http://trac.webkit.org/changeset/197457 |