Bug 154799

Summary: [[IsExtensible]] should be a virtual method in the method table
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
none
patch mark.lam: review+

Description Saam Barati 2016-02-28 13:16:35 PST 
This will make us more consistent with the specification and is necessary for proxies.
Comment 1 Saam Barati 2016-03-01 01:08:16 PST 
Created attachment 272554 [details]
WIP

This is almost done. I just need to audit some call sites of the previous isExtensible().
Comment 2 Saam Barati 2016-03-01 12:24:09 PST 
Created attachment 272584 [details]
patch
Comment 3 Saam Barati 2016-03-01 12:29:31 PST 
Created attachment 272585 [details]
patch
Comment 4 Mark Lam 2016-03-01 12:43:49 PST 
Comment on attachment 272585 [details]
patch

r=me

Do we already tests that exercises the [[IsExtensible]] check?  If not, can we add some?
Comment 5 Saam Barati 2016-03-01 13:33:51 PST 
(In reply to comment #4)
> Comment on attachment 272585 [details]
> patch
> 
> r=me
> 
> Do we already tests that exercises the [[IsExtensible]] check?  If not, can
> we add some?

Thanks for the review.
We already have tests. I'll also be adding more as I work on Proxy.[[IsExtensible]]/Proxy.[[PreventExtensions]]
Comment 6 Saam Barati 2016-03-01 13:45:28 PST 
landed in:
http://trac.webkit.org/changeset/197412