Bug 154799

Summary: [[IsExtensible]] should be a virtual method in the method table
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
none
patch mark.lam: review+

Saam Barati
Reported 2016-02-28 13:16:35 PST
This will make us more consistent with the specification and is necessary for proxies.
Attachments
WIP (18.46 KB, patch)
2016-03-01 01:08 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (21.46 KB, patch)
2016-03-01 12:24 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (21.94 KB, patch)
2016-03-01 12:29 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-03-01 01:08:16 PST
Created attachment 272554 [details] WIP This is almost done. I just need to audit some call sites of the previous isExtensible().
Saam Barati
Comment 2 2016-03-01 12:24:09 PST
Created attachment 272584 [details] patch
Saam Barati
Comment 3 2016-03-01 12:29:31 PST
Created attachment 272585 [details] patch
Mark Lam
Comment 4 2016-03-01 12:43:49 PST
Comment on attachment 272585 [details] patch r=me Do we already tests that exercises the [[IsExtensible]] check? If not, can we add some?
Saam Barati
Comment 5 2016-03-01 13:33:51 PST
(In reply to comment #4) > Comment on attachment 272585 [details] > patch > > r=me > > Do we already tests that exercises the [[IsExtensible]] check? If not, can > we add some? Thanks for the review. We already have tests. I'll also be adding more as I work on Proxy.[[IsExtensible]]/Proxy.[[PreventExtensions]]
Saam Barati
Comment 6 2016-03-01 13:45:28 PST
landed in: http://trac.webkit.org/changeset/197412
Note You need to log in before you can comment on or make changes to this bug.