Summary: | [iOS Simulator] Reftests don't work | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dbates, glenn, lforschler, mmaxfield, ryanhaddad, simon.fraser, thorton, zalan | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=154761 | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2016-02-26 17:23:43 PST
Created attachment 272389 [details]
proposed fix
(In reply to comment #0) > ImageDiff doesn't work in iOS simulator - all failing tests say "ref test > hashes didn't match but diff passed". All of them? Don't we have an "expected mismatch" test that fails when ref tests aren't working? Comment on attachment 272389 [details] proposed fix Clearing flags on attachment: 272389 Committed r197227: <http://trac.webkit.org/changeset/197227> All reviewed patches have been landed. Closing bug. Presumably all expected mismatch tests are already marked as failing or skipped, because of this bug. Now that reftests work, there is a number of failing tests. https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r197255%20(3477)/results.html Mass marked them as failing in <http://trac.webkit.org/r197258>. They need triage, it's mostly text and layout issues. We should probably have a directory of unskippable tests (like fast/harness) that make sure the harness is working. We didn't really have much trouble detecting that something was wrong, and guessing that reftests were completely broken. The problem was with finding the time to investigate the issue. |