Bug 154763

Summary:

Reduce size of internal windows build output

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2016-02-26 17:04:04 PST

Reduce size of internal windows build output

Comment 1 Alex Christensen 2016-02-26 17:04:31 PST

Created attachment 272383 [details]
Patch

Comment 2 WebKit Commit Bot 2016-02-26 17:05:48 PST

Attachment 272383 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Alex Christensen 2016-02-26 17:10:58 PST

Created attachment 272384 [details]
Patch

Comment 4 Alex Christensen 2016-02-26 17:12:41 PST

This reduces the binary size of WTF.dll from 1740kb to 523kb, which is about what it was before the switch to CMake.
Also, we were building debug builds by default internally instead of specifying /p:Configuration=Release.

Comment 5 Alex Christensen 2016-02-26 17:24:09 PST

rdar://problem/24747822

Comment 6 Brent Fulgham 2016-03-01 13:39:55 PST

Comment on attachment 272384 [details]
Patch

r=me

Comment 7 WebKit Commit Bot 2016-03-01 14:29:32 PST

Comment on attachment 272384 [details]
Patch

Clearing flags on attachment: 272384

Committed r197414: <http://trac.webkit.org/changeset/197414>

Comment 8 WebKit Commit Bot 2016-03-01 14:29:35 PST

All reviewed patches have been landed.  Closing bug.