Bug 154763

Summary: Reduce size of internal windows build output
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2016-02-26 17:04:04 PST
Reduce size of internal windows build output
Attachments
Patch (8.18 KB, patch)
2016-02-26 17:04 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (8.15 KB, patch)
2016-02-26 17:10 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-02-26 17:04:31 PST
Created attachment 272383 [details] Patch
WebKit Commit Bot
Comment 2 2016-02-26 17:05:48 PST
Attachment 272383 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2016-02-26 17:10:58 PST
Created attachment 272384 [details] Patch
Alex Christensen
Comment 4 2016-02-26 17:12:41 PST
This reduces the binary size of WTF.dll from 1740kb to 523kb, which is about what it was before the switch to CMake. Also, we were building debug builds by default internally instead of specifying /p:Configuration=Release.
Alex Christensen
Comment 5 2016-02-26 17:24:09 PST
rdar://problem/24747822
Brent Fulgham
Comment 6 2016-03-01 13:39:55 PST
Comment on attachment 272384 [details] Patch r=me
WebKit Commit Bot
Comment 7 2016-03-01 14:29:32 PST
Comment on attachment 272384 [details] Patch Clearing flags on attachment: 272384 Committed r197414: <http://trac.webkit.org/changeset/197414>
WebKit Commit Bot
Comment 8 2016-03-01 14:29:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.