Bug 154733

Summary: Add WTF::OptionSet and use it for the website data types enum
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Anders Carlsson
Reported 2016-02-26 10:41:35 PST
Add WTF::OptionSet and use it for the website data types enum
Attachments
Patch (99.00 KB, patch)
2016-02-26 10:48 PST, Anders Carlsson 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-02-26 10:48:54 PST
Created attachment 272339 [details] Patch
WebKit Commit Bot
Comment 2 2016-02-26 10:51:43 PST
Attachment 272339 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:64: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:153: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:478: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:698: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:121: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:135: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:146: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebProcessProxy.cpp:724: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebProcessProxy.cpp:738: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebProcessProxy.cpp:751: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebProcessProxy.h:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebProcessProxy.h:125: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebProcessProxy.h:126: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:53: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:54: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 24 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2016-02-26 11:34:16 PST
Comment on attachment 272339 [details] Patch r=me
Sam Weinig
Comment 4 2016-02-26 11:38:43 PST
r=me
Anders Carlsson
Comment 5 2016-02-26 11:49:32 PST
Committed r197191: <http://trac.webkit.org/changeset/197191>
Note You need to log in before you can comment on or make changes to this bug.