Bug 154727

Summary: Remove unused CFNetwork disk cache mmap optimization in WebKit2.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Page LoadingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, cgarcia, commit-queue, darin, koivisto, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2016-02-26 08:33:58 PST 
The CFNetwork disk cache mmap optimization is no longer used since the introduction of the WK2 network disk cache.
We can remove the related code since it's never used.
Comment 1 Andreas Kling 2016-02-26 08:39:00 PST 
Created attachment 272327 [details]
Patch
Comment 2 WebKit Commit Bot 2016-02-26 10:17:08 PST 
Comment on attachment 272327 [details]
Patch

Clearing flags on attachment: 272327

Committed r197177: <http://trac.webkit.org/changeset/197177>
Comment 3 WebKit Commit Bot 2016-02-26 10:17:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2016-02-29 03:47:03 PST 
(In reply to comment #2)
> Comment on attachment 272327 [details]
> Patch
> 
> Clearing flags on attachment: 272327
> 
> Committed r197177: <http://trac.webkit.org/changeset/197177>

It broke the Apple Mac Cmake build:

CMake Error at Source/cmake/WebKitMacros.cmake:248 (add_library):
  Cannot find source file:

    NetworkProcess/mac/NetworkDiskCacheMonitor.mm
Comment 5 Csaba Osztrogonác 2016-02-29 03:47:42 PST 
speculative fix landed in http://trac.webkit.org/changeset/197346