Bug 154710

Summary: Array prototype JS builtins should support Symbol.species
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, mark.lam, msaboff, rniwa, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Archive of layout-test-results from ews103 for mac-yosemite
none
Archive of layout-test-results from ews113 for mac-yosemite
none
Benchmark results
none
Patch for landing none

Description Keith Miller 2016-02-25 19:34:26 PST 
Array prototype JS builtins should support Symbol.species
Comment 1 Keith Miller 2016-02-25 20:05:47 PST 
Created attachment 272284 [details]
Patch
Comment 2 Build Bot 2016-02-25 21:03:45 PST 
Comment on attachment 272284 [details]
Patch

Attachment 272284 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/884337

New failing tests:
fast/profiler/built-in-function-calls-user-defined-function.html
fast/profiler/built-in-function-calls-anonymous.html
Comment 3 Build Bot 2016-02-25 21:03:48 PST 
Created attachment 272291 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-02-25 21:05:14 PST 
Comment on attachment 272284 [details]
Patch

Attachment 272284 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/884351

New failing tests:
fast/profiler/built-in-function-calls-user-defined-function.html
fast/profiler/built-in-function-calls-anonymous.html
Comment 5 Build Bot 2016-02-25 21:05:17 PST 
Created attachment 272292 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-02-25 21:12:10 PST 
Comment on attachment 272284 [details]
Patch

Attachment 272284 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/884353

New failing tests:
fast/profiler/built-in-function-calls-user-defined-function.html
fast/profiler/built-in-function-calls-anonymous.html
Comment 7 Build Bot 2016-02-25 21:12:12 PST 
Created attachment 272294 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Geoffrey Garen 2016-02-26 00:15:53 PST 
Comment on attachment 272284 [details]
Patch

EWS is angry.
Comment 9 Keith Miller 2016-02-26 08:37:30 PST 
Comment on attachment 272284 [details]
Patch

EWS those tests just need a rebaseline. I can do that before committing.
Comment 10 Keith Miller 2016-02-26 10:14:12 PST 
Created attachment 272334 [details]
Benchmark results
Comment 11 Geoffrey Garen 2016-03-02 14:35:58 PST 
Comment on attachment 272284 [details]
Patch

r=me
Comment 12 Keith Miller 2016-03-03 17:05:16 PST 
Created attachment 272802 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2016-03-03 17:56:31 PST 
Comment on attachment 272802 [details]
Patch for landing

Clearing flags on attachment: 272802

Committed r197536: <http://trac.webkit.org/changeset/197536>
Comment 14 WebKit Commit Bot 2016-03-03 17:56:35 PST 
All reviewed patches have been landed.  Closing bug.