Bug 154703

Summary: REGRESSION (r196744): NetworkExtension.framework and NEFilterSource class are not available on Recovery partition
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Page LoadingAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, beidson, commit-queue, ddkilzer, kling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154364    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description David Kilzer (:ddkilzer) 2016-02-25 16:44:46 PST
The NetworkExtension.framework and the NEFilterSource Objective-C class are not available on the Recovery partition, so we need to make their soft-linking optional to prevent a release assert crash at runtime (due to the fix for Bug 154364).

Bug 154364: [Cocoa] Always check the return value of dlopen() and dlsym() in Release builds
<https://bugs.webkit.org/show_bug.cgi?id=154364>
<http://trac.webkit.org/changeset/196744>
Comment 1 David Kilzer (:ddkilzer) 2016-02-25 16:45:51 PST
<rdar://problem/24845077>
Comment 2 David Kilzer (:ddkilzer) 2016-02-25 16:47:51 PST
Created attachment 272264 [details]
Patch
Comment 3 Andy Estes 2016-02-25 17:14:36 PST
Comment on attachment 272264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272264&action=review

> Source/WebCore/ChangeLog:13
> +        behavior when getNEFilterSourceClass() returned nullptr.

It returns nil, technically :)
Comment 4 WebKit Commit Bot 2016-02-25 18:03:55 PST
Comment on attachment 272264 [details]
Patch

Clearing flags on attachment: 272264

Committed r197154: <http://trac.webkit.org/changeset/197154>
Comment 5 WebKit Commit Bot 2016-02-25 18:03:59 PST
All reviewed patches have been landed.  Closing bug.