Summary: | RefCounter value changed callback should be called on all changes (not just zero edge). | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||||
Component: | Web Template Framework | Assignee: | Gavin Barraclough <barraclough> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue | ||||||||
Priority: | P2 | ||||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Gavin Barraclough
2016-02-25 15:54:10 PST
Created attachment 272255 [details]
WIP
Created attachment 272261 [details]
Fix
Comment on attachment 272261 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=272261&action=review > Source/WTF/wtf/RefCounter.h:60 > + enum Event { Decrement, Increment }; I would use enum class here. > Source/WTF/wtf/RefCounter.h:61 > + using ValueChangeFunction = std::function<void(Event)>; Space after the return type. > Source/WTF/wtf/RefCounter.h:63 > + RefCounter(ValueChangeFunction = [](bool) { }); Maybe use nullptr here (and check m_valueChangeFunction) Created attachment 272273 [details]
Fix
Attachment 272273 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/WebProcessPool.cpp:162: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ProcessThrottler.cpp:39: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WTF/wtf/RefCounter.h:61: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/platform/VNodeTracker.cpp:43: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/VNodeTracker.cpp:42: More than one command on the same line in if [whitespace/parens] [4]
Total errors found: 5 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 272273 [details]
Fix
r=me
Transmitting file data .............. Committed revision 197178. |