Bug 154697

Summary: Import Chakra tests to JSC
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, mkwst, msaboff, oliver, ryanhaddad, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch with just the changed or new pieces. saam: review+

Saam Barati
Reported 2016-02-25 14:59:52 PST
...
Attachments
Patch (deleted)
2016-08-26 17:10 PDT, Michael Saboff 		no flags
Details
Patch with just the changed or new pieces. (171.29 KB, patch)
2016-08-26 17:42 PDT, Michael Saboff 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-02-25 20:28:46 PST
Cooooooool!
JF Bastien
Comment 2 2016-08-26 13:36:24 PDT
Very cool :)
Michael Saboff
Comment 3 2016-08-26 17:10:48 PDT
Created attachment 287177 [details] Patch
Michael Saboff
Comment 4 2016-08-26 17:14:29 PDT
The interesting files are: Source/JavaScriptCore/jsc.cpp Tools/Scripts/run-jsc-stress-tests JSTests/ChakraCore.yaml
Saam Barati
Comment 5 2016-08-26 17:29:06 PDT
rs=me Let's just make sure our licenses our compatible.
Saam Barati
Comment 6 2016-08-26 17:30:09 PDT
(In reply to comment #5) > rs=me > Let's just make sure our licenses our compatible. (I'm not pushing r+ because I can't get anything on bugzilla to actually load the diff. I looked at the diff in my text editor). Also, can you post a follow up bug to turn this on by default or have some way to have it run on bots by default?
Michael Saboff
Comment 7 2016-08-26 17:42:22 PDT
Created attachment 287181 [details] Patch with just the changed or new pieces.
WebKit Commit Bot
Comment 8 2016-08-26 17:43:38 PDT
Attachment 287181 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jsc.cpp:2046: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 9 2016-08-26 17:48:37 PDT
(In reply to comment #8) > Attachment 287181 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/jsc.cpp:2046: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Total errors found: 1 in 8 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. I fixed this locally.
Ryan Haddad
Comment 10 2016-09-02 11:22:01 PDT
I released this patch from EWS because it seems to cause it to hang indefinitely when trying to run.
Alexey Proskuryakov
Comment 11 2016-09-02 15:32:11 PDT
The content of attachment 287177 [details] has been deleted by Alexey Proskuryakov <ap@webkit.org> who provided the following reason: too big, fails to download The token used to delete this attachment was generated at 2016-09-02 15:31:41 PDT.
Saam Barati
Comment 12 2016-09-07 13:31:50 PDT
Michael landed it in: https://trac.webkit.org/changeset/205387
Michael Saboff
Comment 13 2016-09-07 13:38:43 PDT
Change landed in changes https://trac.webkit.org/changeset/205387 Followup fix landed in https://trac.webkit.org/changeset/205389
Note You need to log in before you can comment on or make changes to this bug.