Bug 154692

Summary: REGRESSION (188611): Search field Cancel button should not overlap search text on extensions page.
Product: WebKit Reporter: zalan <zalan>
Component: FormsAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=156007
Bug Depends on: 154730    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2016-02-25 14:27:57 PST 
1. go to https://safari-extensions.apple.com
2. type some text in search field
Text scrolls behind Cancel button.
Comment 1 zalan 2016-02-25 14:28:12 PST 
rdar://problem/22840453
Comment 2 zalan 2016-02-25 16:13:14 PST 
Created attachment 272258 [details]
Patch
Comment 3 Brent Fulgham 2016-02-25 20:22:49 PST 
Comment on attachment 272258 [details]
Patch

I think this looks good. r=me.
Comment 4 WebKit Commit Bot 2016-02-26 09:00:45 PST 
Comment on attachment 272258 [details]
Patch

Clearing flags on attachment: 272258

Committed r197167: <http://trac.webkit.org/changeset/197167>
Comment 5 WebKit Commit Bot 2016-02-26 09:00:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2016-02-26 10:06:44 PST 
Re-opened since this is blocked by bug 154730
Comment 7 zalan 2016-02-26 11:08:47 PST 
Created attachment 272345 [details]
Patch
Comment 8 WebKit Commit Bot 2016-02-26 19:32:47 PST 
Comment on attachment 272345 [details]
Patch

Rejecting attachment 272345 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 272345, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/888567
Comment 9 zalan 2016-02-26 20:05:31 PST 
Created attachment 272395 [details]
Patch
Comment 10 WebKit Commit Bot 2016-02-26 20:07:49 PST 
Comment on attachment 272395 [details]
Patch

Rejecting attachment 272395 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 272395, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/888715
Comment 11 zalan 2016-02-26 20:13:15 PST 
Created attachment 272396 [details]
Patch
Comment 12 WebKit Commit Bot 2016-02-26 21:11:04 PST 
Comment on attachment 272396 [details]
Patch

Clearing flags on attachment: 272396

Committed r197234: <http://trac.webkit.org/changeset/197234>
Comment 13 WebKit Commit Bot 2016-02-26 21:11:08 PST 
All reviewed patches have been landed.  Closing bug.