Bug 15469

Summary: feature branch has 100's of implicit double -> float conversions
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: SVGAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Woo! Fix!
eric: review-
Woo! Another Fix! sam: review+

Oliver Hunt
Reported 2007-10-11 16:17:41 PDT
feature bracnh has 100's of implicit double -> float conversions, these cause compile times failures is -Wshorten-64-to-32 is enabled, which it will need to be on trunk.
Attachments
Woo! Fix! (93.59 KB, patch)
2007-10-11 17:04 PDT, Oliver Hunt 		eric: review-
DetailsFormatted DiffDiff
Woo! Another Fix! (98.25 KB, patch)
2007-10-11 20:37 PDT, Oliver Hunt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2007-10-11 17:04:42 PDT
Created attachment 16635 [details] Woo! Fix!
Eric Seidel (no email)
Comment 2 2007-10-11 19:44:45 PDT
Comment on attachment 16635 [details] Woo! Fix! Too many little issues discussed over IRC. We should see a new version of this patch before landing.
Oliver Hunt
Comment 3 2007-10-11 20:37:16 PDT
Created attachment 16638 [details] Woo! Another Fix!
Oliver Hunt
Comment 4 2007-10-11 22:16:43 PDT
Bug fix landed r26380
Note You need to log in before you can comment on or make changes to this bug.