Bug 15458

Summary: SVG Renderers should PULL localTransform instead of the DOM pushing
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
the fix mjs: review+

Eric Seidel (no email)
Reported 2007-10-10 15:59:52 PDT
SVG Renderers should PULL localTransform instead of the DOM pushing The attached patch fixes this.
Attachments
the fix (58.21 KB, patch)
2007-10-10 16:00 PDT, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-10-10 16:00:17 PDT
Created attachment 16618 [details] the fix
Oliver Hunt
Comment 2 2007-10-10 19:12:33 PDT
Comment on attachment 16618 [details] the fix RenderForeignObject:: m_localTransformDirty would be clearer is called m_localTransformIsDirty Otherwise this seems sane. While it appears saner than the old design i fail to see how this is meant to fix any of the perf issues you were rambling about :D
Eric Seidel (no email)
Comment 3 2007-10-10 20:22:42 PDT
Landed as r26352 on feature branch
Maciej Stachowiak
Comment 4 2007-10-11 23:44:50 PDT
Comment on attachment 16618 [details] the fix marking r+ since this is approved and landed
Note You need to log in before you can comment on or make changes to this bug.