Summary: | CSP: Make SecurityPolicyViolationEvent more closely conform to CSP spec and enable it by default | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | aestes, bfulgham, buildbot, cdumez, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan, mkwst, rniwa, webkit-bug-importer, wilander | ||||||||||||
Priority: | P2 | Keywords: | InRadar, WebExposed | ||||||||||||
Version: | WebKit Local Build | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Daniel Bates
2016-02-21 15:50:00 PST
The attribute statusCode in the definition of SecurityPolicyViolationEvent was changed from DOMString to unsigned short and this attribute was added to the definition of SecurityPolicyViolationEventInit in section Violation DOM Events of the Content Security Policy Level 3 spec., <https://w3c.github.io/webappsec-csp/> (24 February 2016). Created attachment 272119 [details]
Patch and Layout Test
Comment on attachment 272119 [details] Patch and Layout Test Attachment 272119 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/878332 New failing tests: js/dom/global-constructors-attributes.html Created attachment 272128 [details]
Archive of layout-test-results from ews100 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 272119 [details] Patch and Layout Test Attachment 272119 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/878334 New failing tests: js/dom/global-constructors-attributes.html Created attachment 272129 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 272119 [details] Patch and Layout Test Attachment 272119 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/878335 New failing tests: js/dom/global-constructors-attributes.html Created attachment 272131 [details]
Archive of layout-test-results from ews115 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 272155 [details]
Patch and Layout Tests
Update expected result for test js/dom/global-constructors-attributes.html
Comment on attachment 272155 [details] Patch and Layout Tests View in context: https://bugs.webkit.org/attachment.cgi?id=272155&action=review r=me. > Source/WebCore/page/csp/ContentSecurityPolicy.cpp:364 > + columnNumber = 0; Consider 0-initializing when declared, and avoid this 'else' clause. I suppose there is a possible (small) performance hit but it's probably negligible. (In reply to comment #11) > [...] > > Source/WebCore/page/csp/ContentSecurityPolicy.cpp:364 > > + columnNumber = 0; > > Consider 0-initializing when declared, and avoid this 'else' clause. I > suppose there is a possible (small) performance hit but it's probably > negligible. Will initialize lineNumber and columnNumber to 0 at the site of their declaration (line 354 and line 355, respectively) before landing. Committed r197118: <http://trac.webkit.org/changeset/197118> |