Bug 154507

Summary: Use of inlined asm statements causes problems for -std=c99 builds
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: Web Template FrameworkAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. mitz: review+

Mark Lam
Reported 2016-02-20 21:39:33 PST
WTF's Assertions.h may inadvertantly get included by other projects that are built with -std=c99. The use of the inlined asm statements with the keyword "asm" is not recognized when the -std compiler flag is used. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html says "When writing code that can be compiled with -ansi and the various -std options, use __asm__ instead of asm (see Alternate Keywords)." So, to be a good citizen, we can change the use of "asm" in CRASH() to "__asm__" so that we don't break the build of such other projects.
Attachments
proposed patch. (3.16 KB, patch)
2016-02-20 21:52 PST, Mark Lam 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-02-20 21:41:50 PST
Ditto for bmalloc's BAssert.h.
Mark Lam
Comment 2 2016-02-20 21:52:36 PST
Created attachment 271874 [details] proposed patch.
mitz
Comment 3 2016-02-20 21:55:07 PST
Comment on attachment 271874 [details] proposed patch. Not sure the bmalloc part is necessary, but r=me anyway.
Mark Lam
Comment 4 2016-02-20 22:08:20 PST
<rdar://problem/24756943>
Mark Lam
Comment 5 2016-02-20 22:15:22 PST
Thanks for the review. Landed in r196871: <http://trac.webkit.org/r196871>.
Note You need to log in before you can comment on or make changes to this bug.