Bug 154500

Summary: Enhance Logging: Redirect existing logging macros
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Web Template FrameworkAssignee: Keith Rollin <krollin>
Status: RESOLVED WONTFIX    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154499    
Bug Blocks: 154501    
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2016-02-20 11:54:17 PST
Redirect some existing logging macros to call the "always on" macros. This is in an attempt to capture error conditions that occur in the wild that normally wouldn't get logged outside of a debug build. Some macros being redirected are LOG_ERROR, LOG_FATAL, and RELEASE_ASSERT.
Attachments
Patch (8.52 KB, patch)
2016-02-23 13:52 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-20 11:54:36 PST
<rdar://problem/24757740>
Keith Rollin
Comment 2 2016-02-23 13:52:45 PST
Created attachment 272049 [details] Patch
Keith Rollin
Comment 3 2016-02-23 13:53:44 PST
This patch got attached to the wrong bug.
Keith Rollin
Comment 4 2019-04-08 17:10:32 PDT
This task isn't really required any more. We have lots of the needed logging being performed with the RELEASE_LOG macros, and redirecting the other logging blindly is not a good idea since it might capture PII.
Note You need to log in before you can comment on or make changes to this bug.