Summary: | Builtins that should not rely on iteration do. | ||
---|---|---|---|
Product: | WebKit | Reporter: | Mark S. Miller <erights> |
Component: | JavaScriptCore | Assignee: | Keith Miller <keith_miller> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | commit-queue, erights, keith_miller, mark.lam, msaboff, saam |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
Mark S. Miller
2016-02-19 14:52:11 PST
Created attachment 271807 [details]
Screenshot showing Safari working and WebKit failing the badbind.html test for this bug
I think this is because of my patch (http://trac.webkit.org/changeset/196734). I didn't realize that arguments iterator was observable from outside it's scope. Working on this now. Although this specific test passes on all other browsers, note that Chrome50 Canary has a similar but different problem: https://bugs.chromium.org/p/v8/issues/detail?id=4769 Created attachment 271926 [details]
Patch
Created attachment 271931 [details]
Benchmark results
Comment on attachment 271926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271926&action=review r=me > Source/JavaScriptCore/builtins/FunctionPrototype.js:33 > + @putByValDirect(argumentValues, i-1, arguments[i]); Spacing around - 1. Comment on attachment 271926 [details] Patch Clearing flags on attachment: 271926 Committed r196949: <http://trac.webkit.org/changeset/196949> All reviewed patches have been landed. Closing bug. |