Bug 154463

Summary:

Re-sync W3C web-platform-tests' html/dom/interfaces.html

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, darin, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2016-02-19 10:26:43 PST

Re-sync W3C web-platform-tests' html/dom/interfaces.html after:
https://github.com/w3c/web-platform-tests/pull/2588

Comment 1 Chris Dumez 2016-02-19 10:37:36 PST

Created attachment 271764 [details]
Patch

Comment 2 Alexey Proskuryakov 2016-02-19 10:46:28 PST

Comment on attachment 271764 [details]
Patch

What about iOS test results?

Comment 3 Chris Dumez 2016-02-19 10:48:03 PST

(In reply to comment #2)
> Comment on attachment 271764 [details]
> Patch
> 
> What about iOS test results?

Are developers really expected to rebaseline tests for all platforms? It seems easier to rebaseline after landing, using the actual results from the bot than to generate the baseline locally for other platforms.

Comment 4 Alexey Proskuryakov 2016-02-19 10:51:36 PST

For a change like this, it seems easier to update the results at least for iOS, as supposedly they are exactly the same.

We do want to run tests on iOS EWS, which will obviously make it a requirement.

I personally still think that this particular test should be simply deleted, maintaining it is a daily annoyance.

Comment 5 Chris Dumez 2016-02-19 10:54:44 PST

Created attachment 271765 [details]
Patch

Comment 6 Chris Dumez 2016-02-19 10:58:09 PST

(In reply to comment #4)
> For a change like this, it seems easier to update the results at least for
> iOS, as supposedly they are exactly the same.
> 
> We do want to run tests on iOS EWS, which will obviously make it a
> requirement.
> 
> I personally still think that this particular test should be simply deleted,
> maintaining it is a daily annoyance.

Only because it is being actively worked on and we are making daily progress on it. I don't see it as being a long term issue as our pass-rate on this test is becoming really good.

This test certainly has been very useful to me.

Comment 7 WebKit Commit Bot 2016-02-19 13:02:41 PST

Comment on attachment 271765 [details]
Patch

Clearing flags on attachment: 271765

Committed r196830: <http://trac.webkit.org/changeset/196830>

Comment 8 WebKit Commit Bot 2016-02-19 13:02:46 PST

All reviewed patches have been landed.  Closing bug.