Bug 154441

Summary:

Web Inspector: Implement autocompletion for CSS variables

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Mockup	none
Patch	joepeck: review+
[Image] After Patch is applied	none
Patch	none

Nikita Vasilyev

Reported 2016-02-18 23:37:21 PST

Created attachment 271738 [details] [Image] Mockup It would be nice to show an autocomplete pop-over for CSS variables. Neither Chrome DevTools nor Firefox DevTools has it yet.

Attachments
[Image] Mockup (48.96 KB, image/png) 2016-02-18 23:37 PST, Nikita Vasilyev	no flags	Details
Patch (1.99 KB, patch) 2017-04-12 14:29 PDT, Devin Rousso	joepeck: review+	Details Formatted Diff Diff
[Image] After Patch is applied (41.08 KB, image/png) 2017-04-12 14:29 PDT, Devin Rousso	no flags	Details
Patch (1.88 KB, patch) 2017-04-13 23:23 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-02-18 23:37:56 PST

<rdar://problem/24737257>

Devin Rousso

Comment 2 2017-04-12 14:29:25 PDT

Created attachment 306936 [details] Patch

Devin Rousso

Comment 3 2017-04-12 14:29:49 PDT

Created attachment 306937 [details] [Image] After Patch is applied

Joseph Pecoraro

Comment 4 2017-04-13 20:30:16 PDT

Comment on attachment 306936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306936&action=review r=me > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:392 > + let variables = properties.filter((property) => /--[\w-]+/.test(property.name) && property.name.startsWith(prefix)); We already have `property.variable` which would let us drop this RegExp match (which looks unnecessarily complex): let variables = properties.filter((property) => property.variable && property.name.startsWith(prefix));

Devin Rousso

Comment 5 2017-04-13 23:23:56 PDT

Created attachment 307096 [details] Patch

WebKit Commit Bot

Comment 6 2017-04-13 23:51:55 PDT

Comment on attachment 307096 [details] Patch Clearing flags on attachment: 307096 Committed r215358: <http://trac.webkit.org/changeset/215358>

WebKit Commit Bot

Comment 7 2017-04-13 23:51:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.