Summary: | Remove vcxproj build system | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||||||||||||
Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | achristensen, fpizlo, fred.wang, ossy | ||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||
Version: | Other | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||
Bug Blocks: | 190948 | ||||||||||||||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2016-02-18 02:19:22 PST
Created attachment 272018 [details]
Patch
WIP patch, let's start with the JavaScriptCore directory.
Created attachment 272019 [details]
Patch
WIP patch, JSC and WebCore directories.
(In reply to comment #2) > Created attachment 272019 [details] > Patch > > WIP patch, JSC and WebCore directories. The patch applies to trunk fine, but svn-apply reports false positive error when removing 0 byte sized files. Created attachment 272020 [details]
Patch
WIP. With svn-apply hack to let EWS test to build with this patch.
Created attachment 272021 [details]
patch
Created attachment 272022 [details]
patch
temporarily don't remove emtpy files to make EWS happy
We have intentionally left these files in the tree. We have not done all the internal validation we need to with the new build system. We will remove them when we do. (In reply to comment #7) > We have intentionally left these files in the tree. We have not done all > the internal validation we need to with the new build system. We will > remove them when we do. The question is if the old build system is still used and working fine or not. If the answer is no, it is dead code and should be removed from the trunk as soon as possible. Just ask Filip about this very important rule. ;) Created attachment 272024 [details]
patch
Created attachment 272025 [details]
patch
Created attachment 272027 [details]
patch
I'm going to proceed with this. There are still a few things that happen to be in the vcxproj directories that we still need, such as DLLLauncherMain.cpp, so this won't be done all in one patch. |