|Summary:||Remove vcxproj build system|
|Product:||WebKit||Reporter:||Csaba Osztrogonác <ossy>|
|Component:||New Bugs||Assignee:||Csaba Osztrogonác <ossy>|
|Severity:||Normal||CC:||achristensen, fpizlo, fred.wang, ossy|
|Bug Depends on:|
Description Csaba Osztrogonác 2016-02-18 02:19:22 PST
https://lists.webkit.org/pipermail/webkit-dev/2015-September/027679.html Windows ports (Apple and WinCairo) switched to cmake 4 months ago, vcxproj files are dead code, we should remove them from the trunk. There are random/speculative changes for these files since then for nothing.
Comment 1 Csaba Osztrogonác 2016-02-23 08:17:59 PST
Comment 2 Csaba Osztrogonác 2016-02-23 08:23:56 PST
Created attachment 272019 [details] Patch WIP patch, JSC and WebCore directories.
Comment 3 Csaba Osztrogonác 2016-02-23 08:43:24 PST
(In reply to comment #2) > Created attachment 272019 [details] > Patch > > WIP patch, JSC and WebCore directories. The patch applies to trunk fine, but svn-apply reports false positive error when removing 0 byte sized files.
Comment 4 Csaba Osztrogonác 2016-02-23 08:46:32 PST
Created attachment 272020 [details] Patch WIP. With svn-apply hack to let EWS test to build with this patch.
Comment 6 Csaba Osztrogonác 2016-02-23 09:11:46 PST
Created attachment 272022 [details] patch temporarily don't remove emtpy files to make EWS happy
Comment 7 Alex Christensen 2016-02-23 09:16:38 PST
We have intentionally left these files in the tree. We have not done all the internal validation we need to with the new build system. We will remove them when we do.
Comment 8 Csaba Osztrogonác 2016-02-23 09:24:03 PST
(In reply to comment #7) > We have intentionally left these files in the tree. We have not done all > the internal validation we need to with the new build system. We will > remove them when we do. The question is if the old build system is still used and working fine or not. If the answer is no, it is dead code and should be removed from the trunk as soon as possible. Just ask Filip about this very important rule. ;)
Comment 12 Alex Christensen 2016-03-04 11:37:32 PST
I'm going to proceed with this. There are still a few things that happen to be in the vcxproj directories that we still need, such as DLLLauncherMain.cpp, so this won't be done all in one patch.