Bug 154354

Summary:

Need listener-based version of runBeforeUnloadConfirmPanel

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Anders Carlsson

Reported 2016-02-17 12:52:09 PST

Need listener-based version of runBeforeUnloadConfirmPanel

Attachments
Patch (28.82 KB, patch) 2016-02-17 12:54 PST, Anders Carlsson	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2016-02-17 12:54:12 PST

Created attachment 271579 [details] Patch

WebKit Commit Bot

Comment 2 2016-02-17 12:55:55 PST

Attachment 271579 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:119: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1520: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1535: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1540: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:2013: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2016-02-17 13:46:14 PST

Committed r196720: <http://trac.webkit.org/changeset/196720>

Note You need to log in before you can comment on or make changes to this bug.