Summary: | SES selftest page crashes on nightly r196694 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark S. Miller <erights> | ||||||||
Component: | JavaScriptCore | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, commit-queue, erights, ggaren, keith_miller, mark.lam, msaboff, oliver, saam, webkit-bug-importer | ||||||||
Priority: | P1 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=154378 | ||||||||||
Attachments: |
|
Description
Mark S. Miller
2016-02-17 12:19:05 PST
This looks like it's probably because of http://trac.webkit.org/changeset/196220. That's the commit that has modified the crashing function, getOwnPropertyDescriptor, this year. Likely to be a regression from: http://trac.webkit.org/changeset/196001 or http://trac.webkit.org/changeset/196145 I am working on this. Created attachment 271592 [details]
Patch
Comment on attachment 271592 [details]
Patch
r=me
Comment on attachment 271592 [details] Patch Clearing flags on attachment: 271592 Committed r196723: <http://trac.webkit.org/changeset/196723> All reviewed patches have been landed. Closing bug. As of r196733 I am now seeing "A problem occurred with this webpage so it was reloaded." most times when I visit https://rawgit.com/tvcutsem/es-lab/master/src/ses/contract.html . It doesn't happen every time. But if I bring up the web inspector, set a breakpoint, and then reload, then it does happen every time closing the web inspector in the process, preventing me from catching ses at a breakpoint. Will attach a screenshot momentarily. Should I reopen this bug or file a fresh one? Created attachment 271617 [details]
SES selftest page now: A problem occurred with this webpage so it was reloaded
(In reply to comment #11) > Created attachment 271617 [details] > SES selftest page now: A problem occurred with this webpage so it was > reloaded Ok, I will take another look and see if I can reproduce. Thank you for verifying the fix. (In reply to comment #11) > Created attachment 271617 [details] > SES selftest page now: A problem occurred with this webpage so it was > reloaded Also, a backtrace is more useful than a screenshot :) You can get the backtrace the .crash file for the com.apple.WebKit.WebContent process from the "console" utility. Looks like a can reproduce the crash but I have to open Web Inspector and reload the page. I filed https://bugs.webkit.org/show_bug.cgi?id=154378 to track it. *** Bug 154349 has been marked as a duplicate of this bug. *** Comment on attachment 271592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271592&action=review > Source/JavaScriptCore/runtime/JSObject.h:1231 > - if ((attributes & Accessor) != (currentAttributes & Accessor)) { > + if ((attributes & Accessor) != (currentAttributes & Accessor) || (attributes & CustomAccessor) != (currentAttributes & CustomAccessor)) { Here’s how I’d write it: auto accessAttributes = Accessor | CustomAccessor; if ((attributes & accessAttributes) != (currentAttributes & accessAttributes)) { Better than the || I think. |