Bug 154328

Summary: REGRESSION (r196620): Web Inspector: When the scrollbars are always visible, the console prompt is 1px taller
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Bug
none
Patch
none
[Image] With the patch applied none

Description Nikita Vasilyev 2016-02-16 21:46:11 PST 
Created attachment 271536 [details]
[Image] Bug

Steps:
1. System Preferences -> General -> Show scroll bars: Always
2. Open Elements tab, look at the bottom right corner

Expected:
The console prompt is the same height as the bottom right section of the styles sidebar.

Actual:
The console prompt is 1px taller than the bottom right section of the styles sidebar.

Notes:
This bug is the opposite of:
Bug 153959 REGRESSION (r195432): Web Inspector: bottom right section of the styles sidebar is 1px taller than the console prompt

In addition to that, zooming in reveals a scrollbar of the console prompt (see the attached image).
Comment 1 Radar WebKit Bug Importer 2016-02-16 21:46:27 PST 
<rdar://problem/24692996>
Comment 2 Nikita Vasilyev 2016-02-16 22:10:08 PST 
(In reply to comment #0)
> In addition to that, zooming in reveals a scrollbar of the console prompt
> (see the attached image).

I thought it's related to this issue, but it doesn't seem to be the case.
Changing "overflow-y: auto" to "hidden" doesn't change anything.
Comment 3 Nikita Vasilyev 2016-02-17 20:20:39 PST 
Created attachment 271619 [details]
Patch
Comment 4 Nikita Vasilyev 2016-02-17 20:26:17 PST 
Created attachment 271622 [details]
[Image] With the patch applied

It works well with the default overlay scrollbars, too.
Comment 5 Timothy Hatcher 2016-02-17 20:38:46 PST 
The frame context picker in the console prompt look a couple pixels low. We should fix that too.
Comment 6 WebKit Commit Bot 2016-02-17 21:27:29 PST 
Comment on attachment 271619 [details]
Patch

Clearing flags on attachment: 271619

Committed r196741: <http://trac.webkit.org/changeset/196741>
Comment 7 WebKit Commit Bot 2016-02-17 21:27:32 PST 
All reviewed patches have been landed.  Closing bug.