Bug 154328

Summary:

REGRESSION (r196620): Web Inspector: When the scrollbars are always visible, the console prompt is 1px taller

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Bug	none
Patch	none
[Image] With the patch applied	none

Nikita Vasilyev

Reported 2016-02-16 21:46:11 PST

Created attachment 271536 [details] [Image] Bug Steps: 1. System Preferences -> General -> Show scroll bars: Always 2. Open Elements tab, look at the bottom right corner Expected: The console prompt is the same height as the bottom right section of the styles sidebar. Actual: The console prompt is 1px taller than the bottom right section of the styles sidebar. Notes: This bug is the opposite of: Bug 153959 REGRESSION (r195432): Web Inspector: bottom right section of the styles sidebar is 1px taller than the console prompt In addition to that, zooming in reveals a scrollbar of the console prompt (see the attached image).

Attachments
[Image] Bug (125.28 KB, image/png) 2016-02-16 21:46 PST, Nikita Vasilyev	no flags	Details
Patch (3.02 KB, patch) 2016-02-17 20:20 PST, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Image] With the patch applied (33.03 KB, image/png) 2016-02-17 20:26 PST, Nikita Vasilyev	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-02-16 21:46:27 PST

<rdar://problem/24692996>

Nikita Vasilyev

Comment 2 2016-02-16 22:10:08 PST

(In reply to comment #0) > In addition to that, zooming in reveals a scrollbar of the console prompt > (see the attached image). I thought it's related to this issue, but it doesn't seem to be the case. Changing "overflow-y: auto" to "hidden" doesn't change anything.

Nikita Vasilyev

Comment 3 2016-02-17 20:20:39 PST

Created attachment 271619 [details] Patch

Nikita Vasilyev

Comment 4 2016-02-17 20:26:17 PST

Created attachment 271622 [details] [Image] With the patch applied It works well with the default overlay scrollbars, too.

Timothy Hatcher

Comment 5 2016-02-17 20:38:46 PST

The frame context picker in the console prompt look a couple pixels low. We should fix that too.

WebKit Commit Bot

Comment 6 2016-02-17 21:27:29 PST

Comment on attachment 271619 [details] Patch Clearing flags on attachment: 271619 Committed r196741: <http://trac.webkit.org/changeset/196741>

WebKit Commit Bot

Comment 7 2016-02-17 21:27:32 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.