Bug 15431 – SVGRenderStyle should store pre-modified resource URIs

• Component: SVG
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

SVGRenderStyle should store pre-modified resource URIs

We have this code all over the place:
getFilterById(document(), SVGURIReference::getTarget(style()->svgStyle()->filter()));

And some other variations as well (manually doing what getTarget does).  Instead, the SVGRenderStyle should store *just* the anchor as an id, or the full url.  HTML does something similar.  This could be done as a CSSValue, I think.  That way we don't have to do lots of string manipulations every time we layout or paint SVG render objects (these string manipulations have shown up in samples in the past).

[Rob Buis]

Created attachment 22114 [details]
First attempt

This moves the getTarget call to the style selector, unfortunately it changes a
lot of testcase text results.
Cheers,

Rob.

[Eric Seidel (no email)]

Comment on attachment 22114 [details]
First attempt

Will this break external references?

[Rob Buis]

Hi Eric,

(In reply to comment #2)
> (From update of attachment 22114 [details] [edit])
> Will this break external references?

Do you mean external references for tref and use? This has not landed yet
and these are not stored in (SVG)RenderStyle.
Cheers,

Rob.

[Eric Seidel (no email)]

Comment on attachment 22114 [details]
First attempt

This is fine.

We'll eventually have to come up with a solution for external references.

[Rob Buis]

Fixed by r35072.